Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce GC churn #109

Merged
merged 1 commit into from
Dec 21, 2021
Merged

reduce GC churn #109

merged 1 commit into from
Dec 21, 2021

Conversation

megagrump
Copy link
Contributor

  • Eliminated temporary table creation in Button, Text, and Image
  • Added a simple cache for Id strings to avoid redundant string concatenations
  • Renamed local stuff that I've touched:
    • Variables: camelCase
    • Types/Modules: PascalCase
    • Constants: UPPERCASE

@flamendless flamendless linked an issue Dec 21, 2021 that may be closed by this pull request
Excessive garbage buildup #103
Open
@flamendless flamendless added enhancement New feature or request v1.0.0 labels Dec 21, 2021
@flamendless
Copy link
Owner

Thanks! Ive reviewed the changes and all seems good

@flamendless flamendless merged commit cee0116 into flamendless:master Dec 21, 2021
@megagrump megagrump deleted the cleanup branch December 22, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive garbage buildup
2 participants
@megagrump @flamendless