Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blondie to v0.4 #251

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Update blondie to v0.4 #251

merged 1 commit into from
Feb 13, 2023

Conversation

nico-abram
Copy link
Contributor

@nico-abram nico-abram commented Feb 10, 2023

Fixes #207

Blondie now uses the pdb-addr2line and symsrv crates instead of microsoft's dbghelp.dll for symbol resolution. This is faster, and resolved a couple bugs.

@djc
Copy link
Contributor

djc commented Feb 10, 2023

You'll need to add a blurb to the deny.toml for the ring license:

[[licenses.clarify]]
name = "ring"
expression = "ISC AND MIT AND OpenSSL"
license-files = [{ path = "LICENSE", hash = 0xbd0eed23 }]

What's the reason for the extensive list of licenses that you introduced in nico-abram/blondie@965b413? In particular, the MPL-2.0 is considered copyleft, which can be tricky.

@djc
Copy link
Contributor

djc commented Feb 10, 2023

(I pushed a change to update the Cargo.lock file with recent dependencies, hopefully this helps with some of the cargo-deny issues.)

@nico-abram
Copy link
Contributor Author

What's the reason for the extensive list of licenses that you introduced in nico-abram/blondie@965b413? In particular, the MPL-2.0 is considered copyleft, which can be tricky.

My understanding was offering multiple licenses in that manner allowed the consumer to pick the one that best suits their needs, so aiming to make it maximumly available I added some of the most commonly accepted licenses. If that complicates things I can remove MPL

Fixes flamegraph-rs#207
Blondie now uses the pdb-addr2line and symsrv crates instead of
microsoft's dbghelp.dll . This is faster, and resolved a couple bugs.
@djc djc merged commit 5dbce35 into flamegraph-rs:main Feb 13, 2023
@djc
Copy link
Contributor

djc commented Feb 13, 2023

Thanks!

My understanding was offering multiple licenses in that manner allowed the consumer to pick the one that best suits their needs, so aiming to make it maximumly available I added some of the most commonly accepted licenses. If that complicates things I can remove MPL

I would recommend sticking with the default of just MIT OR Apache-2.0. Given that MIT already allows most uses (with attribution), this combo should be fine for pretty much everyone (there are good reasons this is the default in the Rust ecosystem).

This is the feedback cargo-deny generates right now, with copyleft = "warn" and allow-osi-fsf-free = "either":

warning[accepted]: license requirements satisfied
  ┌─ blondie 0.4.1 (registry+https://github.com/rust-lang/crates.io-index):4:12
  │
4 │ license = "MIT OR Apache-2.0 OR BSL-1.0 OR MPL-2.0 OR Zlib OR Unlicense"
  │            ^^^----^^^^^^^^^^----^^^^^^^----^^^^^^^----^^^^----^^^^^^^^^
  │            │      │             │          │          │       │
  │            │      │             │          │          │       accepted: license is OSI approved https://opensource.org/licenses
  │            │      │             │          │          accepted: license is OSI approved https://opensource.org/licenses
  │            │      │             │          accepted: license is considered copyleft
  │            │      │             accepted: license is OSI approved https://opensource.org/licenses
  │            │      accepted: license is OSI approved https://opensource.org/licenses
  │            license expression retrieved via Cargo.toml `license`
  │            accepted: license is OSI approved https://opensource.org/licenses
  │
  = blondie v0.4.1
    └── flamegraph v0.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random/intermittent "Input data ends in the middle of a stack." error on Windows with softbuffer
2 participants