fix: permission denied reading stacks file #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds code to execute: sudo chmod $USER cargo-flamegraph.stacks When the following conditions are met: * The flamegraph was generated with dtrace (aka. not on Linux) * The user passed --root on the command line * The USER env is set This ensures the cargo-flamegraph.stacks file wrote by dtrace as "root" is readable by the non-root user.
Removes redundant 'static on const vars.
djc
reviewed
Nov 24, 2021
djc
approved these changes
Nov 24, 2021
|
Thanks @djc! Any chance of getting this merged? |
|
Yup, sorry for the delay. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the
cargo-flamegraph.stacksfile generated when using the dtrace profiler can be read to be collapsed by setting the owner to$USERinstead ofroot👍Fixes #173.
fix: set cargo-flamegraph.stacks file owner (ae0f5d9)
refactor: fix clippy lint (e9164ca)