support rustc --manifest-path option #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Bors r+ |
|
Is bors ignoring us? :( |
|
I guess it needs to be on a line by itself? @bors r+ |
|
Uhh... bors r+ |
|
Build succeeded: |
This was referenced Nov 6, 2021
djc
pushed a commit
that referenced
this pull request
Nov 9, 2021
In the implementation of #121, `--manifest-path` is forwarded to `cargo build` so the correct crate gets built and profiled, however it is not forwarded to `cargo metadata`. This could impact target inference, but more importantly prevented `--manifest-path` from being used in order to profile a crate without being in any crate root e.g. if the crate being profile works off of `$PWD`, `cargo-flamegraph` was not able to run if said `PWD` was not in a crate context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is makes running
cargo flamegraphfor benchmarks from the workspace root very similar tocargo bench.