Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom cargo profiles #167

Closed
frankier opened this issue Nov 2, 2021 · 2 comments · Fixed by #241
Closed

Support custom cargo profiles #167

frankier opened this issue Nov 2, 2021 · 2 comments · Fixed by #241

Comments

@frankier
Copy link

frankier commented Nov 2, 2021

Now that rust-lang/cargo#6988 is stabilized, it might be nice if it were possible to specify any profile rather than just --dev or --release. This was we can have an optimised debug release which is probably optimal for flamegraphing:

[profile.release-debug]
lto = "fat"
codegen-units = 1
debug = true
@djc
Copy link
Contributor

djc commented Nov 2, 2021

Would be happy to have a PR for this, though I'd probably want to hold off merging until --profile is actually available in stable.

@tranzystorekk
Copy link
Contributor

Would be happy to have a PR for this, though I'd probably want to hold off merging until --profile is actually available in stable.

The time has come! 🥳

I wonder if there is a way for flamegraph to provide a default "inherit from release + debug_symbols" profile?

madadam added a commit to madadam/flamegraph that referenced this issue Nov 2, 2022
@madadam
Add support for cargo --profile
3ca8825 
Closes flamegraph-rs#167
@madadam madadam mentioned this issue Nov 2, 2022
Merged
madadam added a commit to madadam/flamegraph that referenced this issue Nov 2, 2022
@madadam
Add support for cargo --profile
171509d 
Closes flamegraph-rs#167
madadam added a commit to madadam/flamegraph that referenced this issue Nov 2, 2022
@madadam
Add support for cargo --profile
2dcb414 
Closes flamegraph-rs#167
@djc djc closed this as completed in #241 Nov 2, 2022
@djc djc closed this as completed in c532c04 Nov 2, 2022
@jtmoon79 jtmoon79 mentioned this issue May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for cargo --profile madadam/flamegraph
3 participants
@djc @frankier @tranzystorekk