Add symbol export macro for all functions #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the initiative on this, Isuru. I assume this will move us close to solving issue #248? |
|
@isuruf Are you comfortable with merging this now? |
|
Yes, this PR doesn't change anything, so ready for merging |
pradeeptrgit
pushed a commit
to amd/blis
that referenced
this pull request
Jan 14, 2020
* initial export of blis functions * Regenerate def file for master * restore bli_extern_defs exporting for now
dzambare
pushed a commit
to amd/blis
that referenced
this pull request
Mar 15, 2021
* initial export of blis functions * Regenerate def file for master * restore bli_extern_defs exporting for now
dzambare
pushed a commit
to amd/blis
that referenced
this pull request
Jul 6, 2021
* initial export of blis functions * Regenerate def file for master * restore bli_extern_defs exporting for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change anything. Just adds an empty macro.
I'll send a separate PR for visibility changes since it'll be easier to review a smaller PR and this PR is too big to have a discussion.