Make sure we don't cache server errors

flack · Jan 4, 2025 · b22f9f4 · b22f9f4
1 parent a2ae32d
commit b22f9f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/midcom/response/styled.php b/lib/midcom/response/styled.php
@@ -21,10 +21,9 @@ class midcom_response_styled extends Response
 
     public function __construct(midcom_core_context $context, string $root_element = 'ROOT')
     {
-        parent::__construct();
         $this->set_context($context);
         $this->root_element = $root_element;
-        $this->content = $this->render();
+        parent::__construct($this->render());
     }
 
     private function render() : string

diff --git a/lib/midcom/services/cache/module/content.php b/lib/midcom/services/cache/module/content.php
@@ -251,7 +251,7 @@ public function on_response(ResponseEvent $event)
             return;
         }
         $response = $event->getResponse();
-        if ($response instanceof BinaryFileResponse) {
+        if ($response instanceof BinaryFileResponse || $response->isServerError()) {
             return;
         }
         foreach ($this->_sent_headers as $header => $value) {