This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Add noUnusedLocals to tsconfig to improve type checks. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update relevant import to support noUnusedLocals.
|
It looks like something is wrong with ngc, I'll relaunch the CI tests. |
|
I also had problems with that locally even with the untouched master branch. It appeared when running npm install. |
|
It's probably coming from this PR, I had another yesterday and it went fine |
|
It looks like there is a breaking change with ngc... I don't have time to look at it this week end, so it'll we next week. |
|
Ok, I actually found it. It's coming from Typescript 2.1 not working with ngc. I fixed the version of typescript to 2.0.8. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update relevant import to support noUnusedLocals.