-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier transformer
#246
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2dac9ba
Add `prettier` transformer
josephfrazier f4191c6
Upgrade to prettier 1.4.4
josephfrazier 0336fa9
Include typescript-eslint-parser and flow-parser in build
josephfrazier 5019ae2
Merge branch 'master' into prettier-transformer
josephfrazier 6927696
Exclude irrelevant prettier parsers from bundle
josephfrazier c1c73df
Upgrade prettier to v1.5.2
josephfrazier 7862cb5
Merge branch 'master' into josephfrazier-prettier-transformer
josephfrazier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
website/src/parsers/js/transformers/prettier/codeExample.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| export default { | ||
| "printWidth": 80, | ||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "semi": false, | ||
| "singleQuote": false, | ||
| "trailingComma": "none", | ||
| "bracketSpacing": true, | ||
| "jsxBracketSameLine": false, | ||
|
|
||
| "parser": "babylon" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import compileModule from '../../../utils/compileModule'; | ||
| import pkg from 'prettier/package.json'; | ||
|
|
||
| const ID = 'prettier'; | ||
| const name = 'prettier'; | ||
|
|
||
| export default { | ||
| id: ID, | ||
| displayName: name, | ||
| version: pkg.version, | ||
| homepage: pkg.homepage, | ||
|
|
||
| defaultParserID: 'babylon7', | ||
|
|
||
| loadTransformer(callback) { | ||
| require(['prettier'], callback); | ||
| }, | ||
|
|
||
| transform(prettier, transformCode, code) { | ||
| const options = compileModule(transformCode); | ||
| return prettier.format(code, options.default || options); | ||
| }, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to upgrade Prettier, you need to provide new regexes to exclude irrelevant parsers (they're structured differently in Prettier now). Unless you want to allow all of the parsers, but then need to check that transform actually works with each of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fixed in 6927696
Since this is a JavaScript/etc transformer, I eliminated the non-JS parsers.