Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check path #31

Merged
merged 31 commits into from
Sep 11, 2019
Merged

Check path #31

merged 31 commits into from
Sep 11, 2019

Conversation

tbarabosch
Copy link
Contributor

This implements the check_path analyzer, which finds pathes from input functions (such as recv and scanf) to CWE hits.

@tbarabosch
adds check_path flag to cwe_checker, adds some symbols to config.json
4cec026 
for testing, improves scons to check for dockcross installation, adds
simple check_path example
@tbarabosch
prototype of check_path implementation
bc204e2
@tbarabosch tbarabosch self-assigned this Jul 26, 2019
Thomas Barabosch and others added 25 commits August 1, 2019 14:13
Some progress..
1381cc2
@tbarabosch
Really close to getting this to work
33638d9
Starting to have basic block granularity
a1350d9
Fixed tid to string conversion issue
8f07b81
Comment on the Bap 1.x.x isseus with Bap.Std.Tid.to_string
e2daaa9
Resolved issue around serialization of tids, now using Tid.name
1e8fc03
[checkpath] WIP
65989f1
First working version of check path implemenation. Started implementa…
1dae3f0 
…tion of proper logging / JSON output.
@tbarabosch
adds check_path flag to cwe_checker, adds some symbols to config.json
603b452 
for testing, improves scons to check for dockcross installation, adds
simple check_path example
@tbarabosch
prototype of check_path implementation
38c5059
Some progress..
da3ae39
@tbarabosch
Really close to getting this to work
248ad11
Starting to have basic block granularity
466c5be
Fixed tid to string conversion issue
994b53b
Comment on the Bap 1.x.x isseus with Bap.Std.Tid.to_string
390810e
Resolved issue around serialization of tids, now using Tid.name
816d9d5
[checkpath] WIP
fa4f8d7
First working version of check path implemenation. Started implementa…
c0b5682 
…tion of proper logging / JSON output.
Fixed logging (native + json), added to README and CHANGES.
eac6bef
Merged master into branch
7c07f6a
Fixed mucked up manual merge
4a343b6
Added support for check_path to cwe_checker_to_ida scripts
261aa99
Fixed broken check in SCons for installed dockcross container
c1cc5e1
Content codacy
47bff6a
Content codacy
893a87e
@tbarabosch tbarabosch marked this pull request as ready for review September 10, 2019 10:11
Enkelmann
Enkelmann suggested changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@Enkelmann Enkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check_path.c artificial sample is not yet used in any checks. We should change that. ;-)

src/utils/log_utils.ml Outdated Show resolved Hide resolved
src/utils/log_utils.mli Show resolved Hide resolved
src/analysis/check_path.ml Outdated Show resolved Hide resolved
@tbarabosch
Copy link
Contributor Author

Please ignore the nagging of codacy. These are just tests!

Enkelmann
Enkelmann approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@Enkelmann Enkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! If you approve of the documentation I added to index.mld for the new command line option, we can merge it.

@tbarabosch
Copy link
Contributor Author

Very nice! If you approve of the documentation I added to index.mld for the new command line option, we can merge it.

Looks fine.

@Enkelmann Enkelmann merged commit 75d6c2b into master Sep 11, 2019
@Enkelmann Enkelmann deleted the check_path branch September 11, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enkelmann Enkelmann Enkelmann approved these changes

Assignees

@tbarabosch tbarabosch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbarabosch @ivg @Enkelmann