Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35 - fix:badge in dashboard dataset is not positioned in the best way #51

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Oct 11, 2024

Description

Right now in staging, the badges in the page dashboard/datasets are not properly styled and literally "invisible", pic below:
image

While this closed PR #49 fixed the color issue:
image

This one add more changes in styling and positioning of the badges:
image

Closes fjelltopp/ckanext-fjelltopp-theme#35

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei self-assigned this Oct 11, 2024
@A-Souhei A-Souhei added bug Something isn't working minor labels Oct 11, 2024
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@A-Souhei A-Souhei merged commit f24e688 into main Oct 11, 2024
2 checks passed
@A-Souhei A-Souhei deleted the 35-fixbadge-in-dashboard-dataset-is-not-positioned-in-the-best-way branch October 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix:badge in dashboard dataset is not positioned in the best way
2 participants