Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187 - Fix homepage group image URL #47

Closed
wants to merge 2 commits into from

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Oct 9, 2024

Description

image

Closes fjelltopp/zarr-ckan#187

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei self-assigned this Oct 9, 2024
@A-Souhei A-Souhei added bug Something isn't working minor labels Oct 9, 2024
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between image_url and image_display_url? Because it works fine on my local system and on staging "as is"

@A-Souhei
Copy link
Contributor Author

A-Souhei commented Oct 9, 2024

It does not work on my local setup, may be I need to reset it then. I will look at it but right now image_display_url is used in core CKAN group/snippets/group_item.html:

  {% block image %}
    <img src="{{ group.image_display_url or h.url_for_static('/base/images/placeholder-group.png') }}" alt="{{ group.name }}" class="media-image img-fluid">
  {% endblock %}

@A-Souhei
Copy link
Contributor Author

A-Souhei commented Oct 9, 2024

I put it as draft to prevent accidental merge.

@A-Souhei A-Souhei marked this pull request as draft October 9, 2024 10:03
@A-Souhei A-Souhei closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quick fix: group image url
2 participants