173 Custom Fields when modifying organisation

[A-Souhei]

Description

Removes custom fields from organization's new and edit pages.

Closes fjelltopp/zarr-ckan#173

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

• The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
• I have developed these changes in discussion with the appropriate project manager.
• My code follows the general Fjelltopp documentation (see Confluence).
• I have made corresponding changes to the Fjelltopp documentation (see Confluence).
• I have rebased this branch with master.
• New dependency changes have been committed.
• I have added automated tests that prove my fix is effective or that my feature works.
• New and existing tests pass locally with my changes.
• My changes generate no new warnings.
• I have performed a self-review of my own code.
• I have assigned at least one reviewer.
• I have assigned at least one label to this PR: "patch", "minor", "major".

[ChasNelson1990]

Where do those fields originally come from?

[A-Souhei]

@ChasNelson1990 , the fields are in the block in zarr-ckan/ckan/ckan/templates/organization/snippets/organization_form.html:

  {% block custom_fields %}
    {% snippet 'snippets/custom_form_fields.html', extras=data.extras, errors=errors, limit=3 %}
  {% endblock %}

[ChasNelson1990]

@A-Souhei - but that block is only handling formatting of the custom fields why do we have these fields in the data dictionary at all?

[A-Souhei]

I will look more at it tomorrow.

[A-Souhei]

@ChasNelson1990 , from snippets/custom_form_fields.html:

  {# Add a max of 3 empty columns #}
  {% set total_extras = extras|count %}
  {% set empty_extras = (limit or 3) - total_extras %}
  {% if empty_extras <= 0 %}{% set empty_extras = 1 %}{% endif %}

This chunk will make it that even if we set limit to 0 in previous comment code, it will add 3 customs fields by default.

Should I update this template instead?

I tried with a vanilla ckan docker compose stack :

[ChasNelson1990]

@A-Souhei do we know why this was added? Or when, is it recent? Is there a good reason?

[A-Souhei]

Some interesting discussions about it :
ckan/ckan#6037

[ChasNelson1990]

Let's get this merged