Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adx 1021 using a flash message to inform users of profile data updated #9

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Jul 20, 2023

Description

Updates APE return_url to adr /ape_data_receiver

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

kforenc and others added 26 commits June 27, 2023 16:58
# Conflicts:
#	Pipfile.lock
#	ape/logic.py
#	ape/routes.py
#	ape/util.py
@A-Souhei A-Souhei changed the base branch from master to ADX-1014_Babel July 20, 2023 12:36
@A-Souhei A-Souhei marked this pull request as ready for review July 20, 2023 12:37
Base automatically changed from ADX-1014_Babel to master August 1, 2023 11:33
@kforenc
Copy link
Collaborator

kforenc commented Aug 7, 2023

I've noticed there is no lang support (at least it didn't work for me yet).

@tomeksabala tomeksabala requested review from kforenc and removed request for tomeksabala August 7, 2023 15:35
kforenc and others added 3 commits August 9, 2023 18:02
…ve these URLs from session if they weren't passed to home page via URL parameters.
@kforenc kforenc merged commit 12980d3 into master Aug 9, 2023
2 checks passed
@kforenc kforenc deleted the ADX-1021-using-a-flash-message-to-inform-users-of-profile-data-updated branch August 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants