ADX-1014 Add Babel translation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture environment
# Conflicts: # Pipfile.lock # ape/logic.py # ape/routes.py # ape/util.py
…event form resubmission upon page refresh
tomeksabala
requested changes
Jul 10, 2023
| @@ -1,6 +1,7 @@ | |||
| from flask_wtf import FlaskForm | |||
| from wtforms import StringField, SubmitField, EmailField | |||
| from wtforms.validators import DataRequired, Email | |||
| from flask_babel import lazy_gettext as _l | |||
There was a problem hiding this comment.
usually we use only underscore as an alias to gettext. Please change to:
from flask_babel import lazy_gettext as _
There was a problem hiding this comment.
Do we use it for lazy_gettext as well? This convention (_l) was suggested by Miguel Grindberg, as it's a different import. I suggest leave it as is, since lazy_gettext is different than gettext and to see this one would need to look at import statement.
ape/routes.py
Outdated
| + urlencode( | ||
| { | ||
| "returnTo": url_for("main.home", _external=True), | ||
| "client_id": env.get("AUTH0_CLIENT_ID"), |
There was a problem hiding this comment.
AUTH0_CLIENT_ID should be read from config?
tomeksabala
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADX-1014 Add Babel translation
Add translation feature of all messages in application. Move configuration into
Configobject pattern.Dependency Changes (delete if not applicable)
flask-babel has been added in latest version, which changed a bit way of setting up translations comparing to navigator. Namely, the 'locale_selector' is a function passed into babel's
init_app().Testing (delete if not applicable)
Internationalisation and Localisation (delete if not applicable)
Translations to
frandpt_PTdone.Checklist
Put an
xin the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.