Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-1041 Support for custom flash messages passed from ADR #14

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

tomeksabala
Copy link
Member

@tomeksabala tomeksabala commented Aug 31, 2023

Description

  1. Fixed a bug where success flash message and return to after_save_url happened if any flash messages present
  2. Added support for passing a custom flash message on initial request by url arg flash_message.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@tomeksabala tomeksabala merged commit a4b127d into master Aug 31, 2023
2 checks passed
@tomeksabala tomeksabala deleted the adx-1041-required-fields branch August 31, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant