Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emrah feedback #93

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Emrah feedback #93

wants to merge 4 commits into from

Conversation

ediril
Copy link
Collaborator

@ediril ediril commented Feb 12, 2025

The following items are my feedback based on trying to create a source SDK connector. They are not addressed in this PR, we'll need to create separate tickets for them:

  • Java example defines the following:
    private final String INFO = "INFO";
    private final String WARNING = "WARNING";
    private final String SEVERE = "SEVERE";

Examples should use standard logging and configured to log messages to STDOUT. Let's get rid of custom logMessages() method and these string constants.

  • Update example IJ settings to Java 17

@ediril ediril self-assigned this Feb 12, 2025
Copy link

height bot commented Feb 12, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@ediril ediril marked this pull request as draft February 12, 2025 04:31
@ediril ediril marked this pull request as ready for review February 14, 2025 18:10
@alsnkline
Copy link
Collaborator

I created T-891872 Improve V2 Examples for Partners to track these suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants