Bugfix/add schedule holiday #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
||
| -- we'll use these to determine which schedule version to associate tickets with | ||
| split_timezones.valid_from, | ||
| split_timezones.valid_until | ||
|
|
||
| from schedule | ||
| join schedule_holiday |
There was a problem hiding this comment.
should be a left join right?
Comment on lines
22
to
33
| {% if var('using_schedules', True) %} | ||
|
|
||
| ), ticket_schedule as ( | ||
|
|
||
| select * | ||
| from {{ ref('stg_zendesk__ticket_schedule') }} | ||
|
|
||
| ), schedule_holiday as ( | ||
|
|
||
| select * | ||
| from {{ ref('stg_zendesk__schedule_holiday') }} | ||
|
|
There was a problem hiding this comment.
why are we bringing these tables in here now? if we need to, is there a simpler way to bring in the holiday information?
| dbt_date.week_start('schedule_holiday.holiday_end_date_at'), | ||
| 'schedule_holiday.holiday_end_date_at', | ||
| 'second') }} /60 | ||
| ) as holiday_end_time_from_week, |
There was a problem hiding this comment.
what happens if the holiday starts in one week and ends in the other? it'd be ideal to just work with the holiday_start_time_from_week and compute the raw_delta between holiday_start_date_at and holiday_end_date_at right here. this is similar to how we store the end dates of tickets
There was a problem hiding this comment.
or rather dbt_date.week_start should truncate the holiday start date?
…s-14 Package Updater PR
16 tasks
|
Closing this PR as PR #98 includes the relevant changes. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Internal
What change(s) does this PR introduce?
Make downstream updates following the addition of the
schedule_holidaytable. Business resolution time calculations have been updated to account for holidays overlapping with ticket timelines. This includes thefirst_resolution_business_minutes,full_resolution_business_minutes,first_reply_time_business_minutesfields.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Updated logic to existing fields
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.