Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quickstart.yml with proper source tables #57

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Feb 27, 2025

PR Overview

This PR will address the following Issue/Feature: [#56]

This PR will result in the following new package version: v0.8.0

quickstart.yml updates that will raise the model count by default, so breaking change

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Fixed the _credit_note and _bank_transaction table variable naming in quickstart.yml to ensure their respective models are enabled and disabled appropriately.

Submission Checklist

Submitter:

  • [NA] Alignment meeting with the reviewer
    • Due to simplicity of changes, decided not to move forward here.
  • Provide validation details:
    • Validation Steps: Outline how to verify the changes
      • ✅ Make sure quickstart.yml matches connector schema (checked multiple Xero connections to make sure)
      • ✅ Show validation tests are passing
Screenshot 2025-02-27 at 3 03 42 PM
  • Testing Instructions:

    • Would do the same as the validation details.
  • [NA] Focus Areas: Highlight any complex logic or queries needing special attention

    • Nothing particular to call out.

Reviewer:

  • Confirm submission requirements are met

Changelog

  • Draft after PR approval (drafted now since this was simple, but no need for PR reviewer to look at)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

If you had to summarize this PR in an emoji, which would it be?

🖌️

@fivetran-avinash fivetran-avinash self-assigned this Feb 27, 2025
@fivetran-avinash fivetran-avinash linked an issue Feb 27, 2025 that may be closed by this pull request
4 tasks
- local: ../
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd, not sure why this is logging this as a change

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-avinash thanks for this update! I have two callouts that I'd like to be applied before approval. Let me know if you have any questions. Thanks!

CHANGELOG.md Outdated
@@ -1,3 +1,9 @@
# dbt_xero v0.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this may ultimately change the number of models generated due to the variables working as expected, I would prefer we make this a breaking change. I would rather users are aware of the bugfix and realize that this will increase their model counts if these tables are selected in their connection schema tab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

CHANGELOG.md Outdated
# dbt_xero v0.7.1
[PR #54](https://github.com/fivetran/dbt_xero/pull/54) includes the following updates:

## Under the Hood
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually phrase this as a bugfix since this will have an impact on the model count if the tables are selected in the schema tab and present in their destination. As such, let's define this as a bugfix and reword this to ensure the users are aware of the change this may have on their model count.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased.

Copy link
Contributor Author

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Requested changes look good to me, ready for re-review.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-avinash fivetran-avinash merged commit aaf0537 into main Mar 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Variables in quickstart.yml must match connector schema
3 participants