Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added journal_id to model test #40

Merged
merged 3 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ target/
dbt_modules/
logs/
.DS_Store
dbt_packages/
dbt_packages/
env/
package-lock.yml
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
# dbt_xero v0.6.1

[PR #40](https://github.com/fivetran/dbt_xero/pull/40) includes the following updates:

## Test Updates
- The unique combination of columns test within the `xero__general_ledger` model has been updated to include `journal_id` in addition to `journal_line_id` and `source_relation`.
- This update is required as deleted journals may still appropriately be rendered in the general ledger; however, they will have no associated journal lines. As such, there may be unique `journal_id`s with a null `journal_line_id`. This test update will account for this scenario.

## Contributors
- [@jsagasta](https://github.com/jsagasta) ([PR #40](https://github.com/fivetran/dbt_xero/pull/40))

# dbt_xero v0.6.0
## 🎉 Feature Update 🎉
- Databricks compatibility! ([#38](https://github.com/fivetran/dbt_xero/pull/38))
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'xero'
version: '0.6.0'
version: '0.6.1'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
vars:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'xero_integration_tests'
version: '0.6.0'
version: '0.6.1'
profile: 'integration_tests'
config-version: 2
vars:
Expand Down
1 change: 1 addition & 0 deletions models/xero.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ models:
combination_of_columns:
- journal_line_id
- source_relation
- journal_id
columns:
- name: journal_line_id
description: Xero identifier for the journal line.
Expand Down