-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.3 API updates #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash thanks for working through this API update! Your changes look good, I just have a few requests to update the code highlighted in my review below.
Additionally, one more change that needs to be applied before approving:
- Be sure to update the README version of the package as this is a breaking change. I noticed you marked that check as
NA
in the PR submission form. However, since this is a breaking change, we will want to make that update to reference the new version range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz Thanks for noting the lack of a README update! Fixed that and applied all other changes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great! Thanks for working through these. Approved!
PR Overview
This PR will address the following Issue/Feature: [#8]
This PR will result in the following new package version: Version 0.4.0
We are updating old fields and renaming them to current fields based on the API updates, and we ensured backward compatibility by coalescing the two fields.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
stg_tiktok_ads__ad_group_history
,age
has been renamed asage_groups
.stg_tiktok_ads__advertiser
,phone_number
has been renamed ascellphone_number
, andtelephone
has been renamed astelephone_number
.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Renamed fields were appropriately showing from local and seed runs. Running the latest version of package should reflect the renamed fields from the above models.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🕐