-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add conversion metrics #20
Conversation
packages.yml
Outdated
# - package: fivetran/tiktok_ads_source | ||
# version: [">=0.6.0", "<0.7.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_tiktok_ads_source.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just a few documentation and test question/suggestions
CHANGELOG.md
Outdated
|
||
## Under the Hood | ||
- Created `tiktok_ads_persist_pass_through_columns` macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields. | ||
- Updated `conversion` to be an integer rather than a numeric data type in the `tiktok_ads_source` package, as is the expected behavior of the field. To reflect that data type change, **you will need to do a `--full-refresh`. This is a breaking change.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will a full refresh really be required? We don't leverage any incremental logic in this package so I don't believe this needs to be called out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point, will remove
ad_group_id, | ||
sum(clicks) as clicks, | ||
sum(impressions) as impressions, | ||
sum(spend) as spend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include the conversion metrics in these tests (even if just commented out) so we don't forget them when we make future releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for other consistency tests
PR Overview
This PR will address the following Issue/Feature: This is part of the add conversion metrics project
This PR will result in the following new package version: v0.6.0
We are changing the data type of one field in the source package that will change it in the transform, and customers bringing in the new conversion fields previously via passthrough columns will experience errors if they don't update.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates: Conversion Support!
We have added the following source fields to each
tiktok_ads
end model:real_time_conversion
: Number of times your ad resulted in the optimization event you selected.total_purchase_value
: The total value of purchase events that occurred in your app that were recorded by your measurement partner.total_sales_lead_value
: The monetary worth or potential value assigned to a lead generated through ads.total_conversion_value
: The accumulated value oftotal_purchase_value
andtotal_sales_lead_value
.In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.
Breaking Changes (in the
dbt_tiktok_ads_source
package)conversion
to be an integer rather than a numeric data type, as is the expected behavior of the field. To reflect that data type change, you will need to do a--full-refresh
.Under the Hood
tiktok_ads_persist_pass_through_columns
macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.integration_tests
folder for the transformation models (to be used by maintainers only).Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Unfortunately the JSON issue surrounding
age_groups
in thead_group
model did not allow us to fully validate on dev data, so we had to use integration tests to validate nothing looks out of the ordinary.If you had to summarize this PR in an emoji, which would it be?
🕙