-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add customer phone + remove deleted-customer filter #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small comment about updating the CHANGELOG and regenerating the docs.
- No longer filters out deleted customers in `stripe__customer_overview`. | ||
- Persists `is_deleted` field to differentiate between deleted and active customers. | ||
- Note that this is a 🚨 breaking change 🚨, as previously filtered-out records will appear in `stripe__customer_overview`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment from the source where I would prefer we make this it's own section at the top to really highlight this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
packages.yml
Outdated
# - package: fivetran/stripe_source | ||
# version: [">=0.10.0", "<0.11.0"] | ||
# - local: ../../Finance/Stripe/dbt_stripe_source | ||
- git: https://github.com/fivetran/dbt_stripe_source.git | ||
revision: update/customer360 | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to swap before release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for release!
PR Overview
This PR will address the following Issue/Feature:
is_deleted
field instg_stripe__customer
dbt_stripe_source#71phone
column in stg_stripe__customer dbt_stripe_source#70This PR will result in the following new package version:
v0.12.0 because we are changing the output of the customer_overview model -- deleted customers are now included
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
see height task
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📞