feature/product-inventory-api-update #93
Conversation
| measurement_id, | ||
| measurement_weight_value, | ||
| measurement_weight_unit, | ||
| tracked_editable_locked as is_tracked_editable_locked, |
There was a problem hiding this comment.
This is the field currently tracked_editable_editable in the connector. Should be fixed at connector level but noting in case we have to update the spelling here.
There was a problem hiding this comment.
It looks like this is being fixed in the connector before the changes go live. So we should be good here!
There was a problem hiding this comment.
@fivetran-catfritz great work on this PR! I have just a few small comments and also waiting on a final response from eng regarding one last change and testing on a connector with updates. This will be ready for approval after these small changes are provided and we can test on an up to date connector.
| {"name": "compare_at_price", "datatype": dbt.type_float()}, | ||
| {"name": "created_at", "datatype": dbt.type_timestamp()}, | ||
| {"name": "fulfillment_service", "datatype": dbt.type_string()}, |
There was a problem hiding this comment.
Super small request. Can we group all the columns that are "to be deprecated" to be the last columns in this list. This way it's easier to maintain when the time does come to remove the columns.
There was a problem hiding this comment.
Please do the same for the other fields that are to be deprecated in the future.
| measurement_id, | ||
| measurement_weight_value, | ||
| measurement_weight_unit, | ||
| tracked_editable_locked as is_tracked_editable_locked, |
There was a problem hiding this comment.
It looks like this is being fixed in the connector before the changes go live. So we should be good here!
| coalesce(unit_cost_amount, cost) as unit_cost_amount, | ||
| unit_cost_currency_code, |
There was a problem hiding this comment.
Let's review the internal Height ticket as I'm not so sure about this change anymore. We can confirm when checking the updated connector changes.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃