-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lower casing in stg_shopify__metafield fields to avoid metafield errors #69
Conversation
resolves an ambiguous column error when the namespace or key fields have inconsistent casing (capital vs lower case names).
Update stg_shopify__metafield.sql
…/dbt_shopify_source into bugfix/metafield-casing
CHANGELOG.md
Outdated
|
||
## Under the Hood: | ||
## Bug Fixes | ||
Here are the fixes introduced in [PR #69](https://github.com/fivetran/dbt_shopify_source/pull/69): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor, but I think typically when we list multiple changes for 1 PR, we lead with the PR
So "PR #69 includes the following fixes:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed around!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, save for a minor syntax thing in the changelog, so I'll set to approve
PR Overview
This PR will address the following Issue/Feature:
#64
This PR will result in the following new package version:
0.8.3
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
metafield_reference
field instg_shopify__metafield
to fix metafield table breakages upstream when thekey
field has different casing for otherwise identical strings.owner_resource
field instg_shopify__metafield
to ensure identicalvalue
fields with different casing are then correctly pivoted together upstream in the shopify transformation packageget_metafields
macro.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Our development data is limited for testing, but the most important thing is to show that the before-and-after result in
stg_shopify__metafield
and `shopify__shop_metafields.sql is the same. You will want to test the master and the current branch against each other to validate the results hold. Since the customer has already tested out one of these changes on their own side, this should be enough to validate these changes will achieve the intended result.See the Height ticket for more details.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
⬇️