test severity and note

DECISIONLOG.md

@@ -12,4 +12,13 @@ Thus, the source package will create empty (1 row of all `NULL` fields) staging
 
 ## Keeping Deleted Entities 
 
-todo - not filtering out _fivetran_deleted in staging models. when joining these tables together in the transform package, bring in _fivetran_deleted as is_<foreign key table>_deleted
+todo - not filtering out _fivetran_deleted in staging models. when joining these tables together in the transform package, bring in _fivetran_deleted as is_<foreign key table>_deleted
+
+## Accepted Value Test Severity
+
+We test the following columns for accepted values because their values are hard-coded to be pivoted out into columns and/or used as `JOIN` conditions in downstream models.
+- `stg_shopify__price_rule.target_type`: accepted values are `line_item`, `shipping_line`
+- `stg_shopify__price_rule.value_type`: accepted values are `percentage`, `fixed_amount`
+- `stg_shopify__fulfillment.status`: accepted values are `pending`, `open`, `success`, `cancelled`, `error`, `failure`
+
+We have chosen to make the severity of these tests `warn`, as non-accepted values will be filtered out in the transformation models. They will not introduce erroneous data.

models/stg_shopify.yml

@@ -1197,6 +1197,8 @@ models:
         tests:
           - accepted_values:
               values: ['percentage', 'fixed_amount']
+              config:
+                severity: warn # we use these in a JOIN condition in shopify__discounts
 
   - name: stg_shopify__product_image
     description: Table storing hosted images of products.