The big revamp PR! #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
document refund/return mismatch
package updates
…-postres package standardization updates + postgres compat
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
fivetran-joemarkiewicz
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
@fivetran-jamie these updates look good and following the previous PR reviews I feel they are ready to go!
Once the updates from PR #53 are merged in and the docs are regenerated, this will be good to merge into main!
packages.yml
Outdated
Comment on lines
1
to
7
| packages: | ||
| - package: fivetran/shopify_source | ||
| version: [">=0.7.0", "<0.8.0"] | ||
| # - package: fivetran/shopify_source | ||
| # version: [">=0.8.0", "<0.9.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_shopify_source.git | ||
| revision: feature/revamp/update-for-snowflake | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to update before merging
|
@fivetran-jamie same as my request from the source revamp PR. Can you update this PR description to be more informative around what updates are being applied. Even if we just link out to the other PRs, that would be great! |
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Feature/revamp/documentation
…dbt_shopify into feature/package-revamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
merges the following PRs
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.