Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed casing fixes #32

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Collaborator

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR fixes issues where the macros were not operating correctly with Snowflake warehouses with mixed-quoting styles enabled. A more detailed investigation into this issue can be found within dbt-lab/dbt_utils Issue #424

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

This will not result in a breaking change for existing package users.

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🌗

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the bug Something isn't working label Dec 14, 2021
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit f6ec5f8 into main Dec 14, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the bugfix/snowflake-mixed-casing branch December 14, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants