Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugix/account deletes removal #8

Merged
merged 4 commits into from
May 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_sage_intacct_source v0.1.2

## Updates
- Removed the `_fivetran_deleted` filter in the `stg_sage_intacct__gl_account`. We saw there were records in the `gl_detail` table that were associated with accounts that were deleted, which affected our joins and bubbled up later in the final P&L and balance sheet models. By removing the filter the balances tie out. However, we've kept `_fivetran_deleted` as a column so the user may filter that out on their own.
([#8](https://github.com/fivetran/dbt_sage_intacct_source/pull/8))

# dbt_sage_intacct_source v0.1.1

## Updates
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'sage_intacct_source'
version: '0.1.1'
version: '0.1.2'
config-version: 2
require-dbt-version: [">=1.0.0", "<2.0.0"]

Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

name: 'sage_intacct_source_integration_tests'
version: '0.1.1'
version: '0.1.2'
config-version: 2

profile: 'integration_tests'
Expand Down
4 changes: 2 additions & 2 deletions models/stg_sage_intacct__gl_account.sql
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ final as (
from fields
)

select * from final
where not coalesce(_fivetran_deleted, false)
select *
from final