-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/conversions #7
Conversation
will close out issue #3 as well since this is addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie generally this PR looks good. There are a few changes I would like to be addressed before this is ready for approval. Let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Overview
This PR will address the following Issue/Feature:
introduce conversion metrics
This PR will result in the following new package version:
Breaking change. Adding new fields
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
dbt_reddit_ads_source v0.3.0
PR #7 includes the following updates:
Feature: Conversion Metrics
stg_reddit_ads__account_conversions_report
stg_reddit_ads__ad_group_conversions_report
stg_reddit_ads__ad_conversions_report
stg_reddit_ads__campaign_conversions_report
click_through_conversion_attribution_window_month
andview_through_conversion_attribution_window_month
fields in the respective source tables. You may bring in additional windows and fields through thestg_<>_conversions_report
models via the<>_conversions_passthrough_metrics
variable. For information on how to configure these variables, refer to the README.Under the hood
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃