-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out deleted accounts #57
Conversation
Filter deleted accounts from stg table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash This generally looks good. Just need some additional documentation update and then a docs regen!
- name: _fivetran_deleted | ||
description: "{{ doc('_fivetran_deleted') }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definition needs to be added to the other staging models:
stg_quickbooks__bundle
stg_quickbooks__customer
stg_quickbooks__department
stg_quickbooks__item
stg_quickbooks__vendor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz This is ready for re-review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash updates look good. Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Overview
This PR will address the following Issue/Feature: [#55]
This PR will result in the following new package version: 11.0
As deleted records are being filtered out here and in
dbt_quickbooks
, this changes the reporting and warrants a breaking change update.Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Breaking Changes
_fivetran_deleted
field to filter out these records from the following staging models:stg_quickbooks__account
stg_quickbooks__bundle
stg_quickbooks__customer
stg_quickbooks__department
stg_quickbooks__item
stg_quickbooks__vendor
dbt_quickbooks
.Documentation Updates
_fivetran_deleted
field tosrc_quickbooks
andstg_quickbook
yml documentation._fivetran_deleted
field to the above corresponding seed files in integration tests.Contibutors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Models ran and passed, and the new filters did take out deleted records.
If you had to summarize this PR in an emoji, which would it be?
🧢