[Bugfix] New variables to configure account type value filters

[fivetran-avinash]

PR Overview

This PR will address the following Issue/Feature: [#97]

This PR will result in the following new package version:

Not a breaking change as most customers rely on the default values for these fields so only a subset should need to apply these changes.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

• Updated intermediate double entry models that have account_type and account_sub_type filters with configurable variables, since the type names used in the filter can be adjusted internally by QuickBooks customers. The intermediate models where these variables were introduced included:

Updated model	New variables to filter on
int_quickbooks__bill_payment_double_entry	quickbooks__accounts_payable_reference
int_quickbooks__credit_memo_double_entry	quickbooks__accounts_receivable_reference
int_quickbooks__deposit_double_entry	quickbooks__undeposited_funds_reference
int_quickbooks__invoice_double_entry	quickbooks__sales_of_product_income_reference, quickbooks__accounts_receivable_reference
int_quickbooks__payment_double_entry	quickbooks__accounts_receivable_reference

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• [NA] dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

Using development data, I tested adding variables into dbt_project.yml that returned the proper account ids into each double entry model. If the value didn't exist, it would return empty models since the filter would exclude all data. The primary model tested was int_quickbooks__bill_payment_double_entry since it contained sufficient development data to test multiple field values and verify README instructions.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• [NA] DECISIONLOG updates have been updated (if applicable)
• [NA] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🪠

[fivetran-joemarkiewicz]

@fivetran-avinash thanks for working through this update! I only have a few requests to update before this will be good to go. Let me know if you have any questions on my suggested documentation changes.

[fivetran-joemarkiewicz]

@fivetran-avinash these look good! I just have a small suggestion to reword the CHANGELOG. Once that is applied, this will be good to go!

Actually can you hold off on merging just to discuss another change that I would like to include. We can discuss during standup. It has to do with PR #100

[fivetran-joemarkiewicz]

I would actually consider the new variables as the feature and then what how they may be configured as the bugfix. See my suggestion below.

Suggested change

	## 🎉 Feature Update 🎉
	- Updated intermediate double entry models that have `account_type` and `account_sub_type` filters with configurable variables, since the type names used in the filter can be adjusted internally by QuickBooks customers. The intermediate models where these variables were introduced included:
	## 🐛 Bug Fixes 🩹
	| **Updated model** | **New variables to filter on** |
	| ----------| -------------------- |
	| [int_quickbooks__bill_payment_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__bill_payment_double_entry) | `quickbooks__accounts_payable_reference` |
	| [int_quickbooks__credit_memo_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__credit_memo_double_entry) | `quickbooks__accounts_receivable_reference` |
	| [int_quickbooks__deposit_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__deposit_double_entry) | `quickbooks__undeposited_funds_reference` |
	| [int_quickbooks__invoice_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__invoice_double_entry) | `quickbooks__sales_of_product_income_reference`, `quickbooks__accounts_receivable_reference` |
	| [int_quickbooks__payment_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__payment_double_entry) | `quickbooks__accounts_receivable_reference` |
	## 🐛 Bug Fixes 🩹
	- Updated intermediate double entry models that have `account_type` and `account_sub_type` filters with configurable variables, since the type names used in the filter may be different than the defaults for QuickBooks customers.
	## 🎉 Feature Updates 🎉
	- The variables to define the `account_type` and `account_sub_type` references were introduced in the following intermediate models:
	| **Updated model** | **New variables to filter on** |
	| ----------| -------------------- |
	| [int_quickbooks__bill_payment_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__bill_payment_double_entry) | `quickbooks__accounts_payable_reference` |
	| [int_quickbooks__credit_memo_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__credit_memo_double_entry) | `quickbooks__accounts_receivable_reference` |
	| [int_quickbooks__deposit_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__deposit_double_entry) | `quickbooks__undeposited_funds_reference` |
	| [int_quickbooks__invoice_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__invoice_double_entry) | `quickbooks__sales_of_product_income_reference`, `quickbooks__accounts_receivable_reference` |
	| [int_quickbooks__payment_double_entry](https://fivetran.github.io/dbt_quickbooks/#!/model/model.quickbooks.int_quickbooks__payment_double_entry) | `quickbooks__accounts_receivable_reference` |

[fivetran-avinash]

This was fixed.