Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/transaction_id #46

Merged
merged 2 commits into from
Sep 15, 2022
Merged

bugfix/transaction_id #46

merged 2 commits into from
Sep 15, 2022

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Sep 15, 2022

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

  • Within the v0.5.1 release, the transaction_id field was erroneously removed from the quickbooks__general_ledger model. This field has since been added back.
  • Modified the surrogate_key dbt-util macro argument to be a single list instead of individual strings. This was due to a warning error showing in the command line.

image

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

This PR only adds a field that was erroneously removed in the previous patch release. Adding it back in will not cause breaking changes for users.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🆔

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the bug Something isn't working label Sep 15, 2022
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review September 15, 2022 14:01
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully ran and tested locally, and changes look good.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit f97031a into main Sep 15, 2022
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the bugfix/transaction_id branch September 15, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants