Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve docs errors #150

Merged
merged 4 commits into from
Dec 10, 2024
Merged

resolve docs errors #150

merged 4 commits into from
Dec 10, 2024

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Dec 10, 2024

PR Overview

This PR will address the following Issue/Feature: Fix conflicting versions of docs errors. You can see these version of the multiple docs in the below links:
https://github.com/fivetran/dbt_quickbooks/blob/main/docs/catalog.json
https://github.com/fivetran/dbt_quickbooks/blob/main/docs/manifest.json

This PR will result in the following new package version:

This PR is not part of an official release as it's only a docs, non-model update.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Under the Hood

  • Updated catalog.json and manifest.json to resolve undefined docs errors from multiple versions of the documentation being pulled in from current and prior releases.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [NA] dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [NA] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • [NA] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Docs generated on the local run.
Screenshot 2024-12-10 at 1 15 12 PM
Screenshot 2024-12-10 at 1 01 14 PM

If you had to summarize this PR in an emoji, which would it be?

📝

@fivetran-avinash fivetran-avinash self-assigned this Dec 10, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-avinash fivetran-avinash merged commit 69b8e22 into main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants