[Pre-release] Bug fix for net income adjustment for no revenue/expense lines #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in accouning periods
fivetran-joemarkiewicz
requested changes
Nov 18, 2024
There was a problem hiding this comment.
@fivetran-joemarkiewicz Thanks for the quick checks! This PR is ready for re-review.
fivetran-joemarkiewicz
approved these changes
Nov 20, 2024
README.md
Outdated
| @@ -73,7 +73,7 @@ Include the following QuickBooks package version in your `packages.yml` file. | |||
| ```yaml | |||
| packages: | |||
| - package: fivetran/quickbooks | |||
| version: [">=0.16.0", "<0.17.0"] # we recommend using ranges to capture non-breaking changes automatically | |||
| version: v0.17.0-a1 # we recommend using ranges to capture non-breaking changes automatically | |||
There was a problem hiding this comment.
The official version will not include the v once it's on the dbt hub.
Suggested change
| version: v0.17.0-a1 # we recommend using ranges to capture non-breaking changes automatically | |
| version: 0.17.0-a1 # we recommend using ranges to capture non-breaking changes automatically |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test branch for the following changes. This is a pre-release.
Bug Fix
int_quickbooks__retained_earningsto ensure accounting periods with no revenue and expense class lines were accounted for.