Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #120 - missing source_relation joins #121

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

MatteyRitch
Copy link

Please provide your name and company
Matthew Ritchie - Cleartelligence Inc

Link the issue/feature request which this PR is meant to address

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
This PR brings in the source_relation column and uses in joins where applicable to prevent cross joins when the same ids exist in multiple quickbooks sources.

How did you validate the changes introduced within this PR?
I worked @fivetran-reneeli to identify other models where a change was required. I ran and tested each changed models by replacing the code in my dbt project.

Which warehouse did you use to develop these changes?
postgres

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

🐛

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

…tion joins

Includes minor fixes for thequickbooks_balance_sheet sql analysis model
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @MatteyRitch I am going to be picking up this PR review! One quick question before getting started, there may be some changes I need to make to your PR in order to ensure this will pass our tests when we merge your changes to main. Do you have any concern if I make commits directly to your branch in these cases?

@fivetran-reneeli fivetran-reneeli changed the base branch from main to bugfix/source_relations April 24, 2024 18:27
@fivetran-reneeli fivetran-reneeli merged commit cdadc65 into fivetran:bugfix/source_relations Apr 24, 2024
@fivetran-reneeli
Copy link
Contributor

Thanks @MatteyRitch for creating this PR! I have merged this into our working branch to finish off the round of updates before merging into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants