-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update date data type casting #103
Changes from 5 commits
b19d1be
a8f4978
8c13a3c
946237d
20fc693
8e7546c
8250886
9fbc716
9c790b2
15ebcce
89b774d
ee9c5e8
906d8cf
54cd158
2cf8dc6
f6d4fb8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
config-version: 2 | ||
name: 'quickbooks' | ||
|
||
version: '0.11.1' | ||
version: '0.11.2' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would just keep this as 0.11.1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good point |
||
|
||
require-dbt-version: [">=1.3.0", "<2.0.0"] | ||
|
||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
name: 'quickbooks_integration_tests' | ||
|
||
version: '0.11.1' | ||
version: '0.11.2' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would just keep this as 0.11.1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good point |
||
|
||
profile: 'integration_tests' | ||
config-version: 2 | ||
|
@@ -61,30 +61,48 @@ vars: | |
quickbooks_vendor_credit_identifier: "vendor_credit_data" | ||
quickbooks_vendor_identifier: "vendor_data" | ||
|
||
using_purchase_order: True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these variables needed now? Or were they just used for testing? (Not that the integration tests is used by outside customers, but I'm not sure if we want to set the alternative variable logic as the default for future dev work.) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I think that was there for testing. I'll remove it though |
||
using_credit_card_payment_txn: True | ||
|
||
|
||
seeds: | ||
+quote_columns: "{{ true if target.type == 'redshift' else false }}" | ||
quickbooks_integration_tests: | ||
+column_types: | ||
transaction_date: date | ||
due_date: date | ||
bill_line_data: | ||
+column_types: | ||
item_expense_billable_status: "{{ 'varchar(100)' if target.name in ('redshift', 'postgres') else 'string' }}" | ||
account_expense_billable_status: "{{ 'varchar(100)' if target.name in ('redshift', 'postgres') else 'string' }}" | ||
credit_memo_data: | ||
+column_types: | ||
transaction_date: timestamp | ||
deposit_line_data: | ||
+column_types: | ||
deposit_account_id: "{{ 'int64' if target.name == 'bigquery' else 'bigint' }}" | ||
deposit_class_id: "{{ 'int64' if target.name == 'bigquery' else 'bigint' }}" | ||
estimate_data: | ||
+column_types: | ||
transaction_date: timestamp | ||
invoice_data: | ||
+column_types: | ||
due_date: timestamp | ||
transaction_date: timestamp | ||
payment_data: | ||
+column_types: | ||
transaction_date: timestamp | ||
purchase_line_data: | ||
+column_types: | ||
item_expense_billable_status: "{{ 'varchar(100)' if target.name in ('redshift', 'postgres') else 'string' }}" | ||
account_expense_account_id: "{{ 'int64' if target.name == 'bigquery' else 'bigint' }}" | ||
purchase_data: | ||
+column_types: | ||
credit: "{{ 'boolean' if target.name in ('snowflake', 'spark', 'databricks') else 'bool' }}" | ||
refund_receipt_data: | ||
+column_types: | ||
transaction_date: date | ||
sales_receipt_data: | ||
transaction_date: timestamp | ||
purchase_order_data: | ||
+column_types: | ||
transaction_date: date | ||
transaction_date: timestamp | ||
vendor_credit_line_data: | ||
+column_types: | ||
item_expense_billable_status: "{{ 'varchar(100)' if target.name in ('redshift', 'postgres') else 'string' }}" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
bill_payment_id,index,_fivetran_synced,amount,bill_id,check_id,credit_card_charge_id,credit_card_credit_id,deposit_id,expense_id,journal_entry_id,linked_bill_payment_id,vendor_credit_id,bill_payment_credit_card_id | ||
23,0,2020-05-20 14:03:30,38757,19,,,,,,,,, | ||
23,0,2020-05-20 14:03:30,38757,19.25,,,,,,,,, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is weird. I see the original value in the source seed file is 19.25 too, but why is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ooh good catch, I'm not sure why that's there. I'll change those to 19 |
||
135,0,2020-11-01 16:02:01,79137,124,,,,,,,,, | ||
90,0,2020-09-01 16:02:12,74592,89,,,,,,,,, | ||
276,0,2020-12-01 16:02:03,88155,268,,,,,,,,, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
id,amount,bank_account_id,credit_card_account_id,created_at,updated_at,currency_id,transaction_date,_fivetran_deleted | ||
1111,5,5,7,2022-07-21 09:57:41,2022-07-21 09:57:41,USD,2022-07-21,FALSE | ||
2222,10.02,5,7,2020-05-24 19:39:23,2020-05-24 19:39:23,USD,2020-05-19,FALSE | ||
3333,13.52,5,7,2022-09-06 12:12:07,2022-09-06 12:12:07,USD,2022-09-04,FALSE | ||
4444,65.22,5,7,2022-01-05 22:22:11,2022-01-05 22:22:11,USD,2022-01-04,FALSE | ||
id,amount,bank_account_id,credit_card_account_id,created_at,updated_at,currency_id,transaction_date,_fivetran_deleted | ||
1111,5,5,7,2022-07-21 09:57:41,2022-07-21 09:57:41,USD,2022-07-21,FALSE | ||
2222,10.02,5,7,2020-05-24 19:39:23,2020-05-24 19:39:23,USD,2020-05-19,FALSE | ||
3333,13.52,5,7,2022-09-06 12:12:07,2022-09-06 12:12:07,USD,2022-09-04,FALSE | ||
4444,65.22,5,7,2022-01-05 22:22:11,2022-01-05 22:22:11,USD,2022-01-04,FALSE | ||
5555,94.1,5,7,2022-07-09 21:15:24,2022-07-09 21:15:24,USD,2022-06-18,FALSE |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
id,_fivetran_deleted,_fivetran_synced,apply_tax_after_discount,balance,bill_email,billing_address_id,class_id,created_at,currency_id,custom_p_o_number,customer_id,customer_memo,department_id,doc_number,email_status,exchange_rate,global_tax_calculation,home_balance,home_total_amount,payment_method_id,print_status,private_note,remaining_credit,sales_term_id,shipping_address_id,sync_token,total_amount,total_tax,transaction_date,updated_at | ||
2702,FALSE,2020-01-15 0:03:02,FALSE,0,,4,,2018-08-10 19:27:15,USD,,4,05393ead5d6967d305712273b22a7ad4,1,135,NotSet,,,,,,NeedToPrint,,0,,4,1,89051,0,2017-11-13 0:00:00,2018-08-10 19:27:27 | ||
2708,FALSE,2020-01-15 0:03:02,FALSE,0,025eabf1dc2d7418902f24bcf4f8b995,12,,2018-08-10 19:34:00,USD,,21,05393ead5d6967d305712273b22a7ad4,1,139,NotSet,,,,,,NeedToPrint,,0,,12,1,56181,0,2017-11-21 0:00:00,2018-08-10 19:34:11 | ||
2916,FALSE,2020-01-15 0:03:02,FALSE,0,,151,,2018-08-24 20:17:21,USD,,668,,1,205,NotSet,,,,,,NeedToPrint,,0,,151,1,47580,0,2018-08-24 0:00:00,2018-08-24 20:17:57 | ||
2919,FALSE,2020-01-15 0:03:02,FALSE,0,,3890,,2018-08-24 20:22:00,USD,,600,,1,206,NotSet,,,,,,NeedToPrint,,0,,4098,1,98033,0,2018-08-13 0:00:00,2018-08-24 20:22:25 | ||
2921,FALSE,2020-01-15 0:03:02,FALSE,0,,132,,2018-08-24 20:23:55,USD,,594,,1,207,NotSet,,,,,,NeedToPrint,,0,,132,1,67480,0,2018-08-14 0:00:00,2018-08-28 19:57:56 | ||
2924,FALSE,2020-01-15 0:03:02,FALSE,0,,3890,,2018-08-24 20:48:50,USD,,600,,1,208,NotSet,,,,,,NeedToPrint,,0,,4098,1,80865,0,2018-07-26 0:00:00,2018-08-24 20:49:05 | ||
2984,FALSE,2020-01-15 0:03:02,FALSE,0,,4003,,2018-08-29 16:45:04,USD,,599,,1,211,NotSet,,,,,,NeedToPrint,,0,,4259,2,3591,0,2018-07-25 0:00:00,2018-10-29 14:54:47 | ||
2986,FALSE,2020-01-15 0:03:02,FALSE,0,,4003,,2018-08-29 16:46:08,USD,,599,,1,212,NotSet,,,,,,NeedToPrint,,0,,4259,1,60522,0,2018-08-13 0:00:00,2018-08-29 16:46:19 | ||
3072,FALSE,2020-01-15 0:03:02,FALSE,0,,155,,2018-08-31 17:52:46,USD,,672,,1,214,NotSet,,,,,,NeedToPrint,,0,,557,1,17649,0,2018-08-28 0:00:00,2018-08-31 17:53:41 | ||
3089,FALSE,2020-01-15 0:03:02,FALSE,0,d41d8cd98f00b204e9800998ecf8427e,154,,2018-09-06 14:47:55,USD,,671,,1,215,NotSet,,,,,,NeedToPrint,,0,,154,1,16638,0,2018-07-20 0:00:00,2018-09-06 14:48:27 | ||
3093,FALSE,2020-01-15 0:03:02,FALSE,0,,131,,2018-09-06 17:14:05,USD,,593,,1,216,NotSet,,,,,,NeedToPrint,,0,,131,1,84675,0,2018-08-28 0:00:00,2018-09-06 17:14:34 | ||
2702,FALSE,2020-01-15 0:03:02,FALSE,0,,4,,2018-08-10 19:27:15,USD,,4,05393ead5d6967d305712273b22a7ad4,1,135,NotSet,,,,,,NeedToPrint,,0,,4,1,89051,0,2017-11-13 00:00:00,2018-08-10 19:27:27 | ||
2708,FALSE,2020-01-15 0:03:02,FALSE,0,025eabf1dc2d7418902f24bcf4f8b995,12,,2018-08-10 19:34:00,USD,,21,05393ead5d6967d305712273b22a7ad4,1,139,NotSet,,,,,,NeedToPrint,,0,,12,1,56181,0,2017-11-21 00:00:00,2018-08-10 19:34:11 | ||
2916,FALSE,2020-01-15 0:03:02,FALSE,0,,151,,2018-08-24 20:17:21,USD,,668,,1,205,NotSet,,,,,,NeedToPrint,,0,,151,1,47580,0,2018-08-24 00:00:00,2018-08-24 20:17:57 | ||
2919,FALSE,2020-01-15 0:03:02,FALSE,0,,3890,,2018-08-24 20:22:00,USD,,600,,1,206,NotSet,,,,,,NeedToPrint,,0,,4098,1,98033,0,2018-08-13 00:00:00,2018-08-24 20:22:25 | ||
2921,FALSE,2020-01-15 0:03:02,FALSE,0,,132,,2018-08-24 20:23:55,USD,,594,,1,207,NotSet,,,,,,NeedToPrint,,0,,132,1,67480,0,2018-08-14 00:00:00,2018-08-28 19:57:56 | ||
2924,FALSE,2020-01-15 0:03:02,FALSE,0,,3890,,2018-08-24 20:48:50,USD,,600,,1,208,NotSet,,,,,,NeedToPrint,,0,,4098,1,80865,0,2018-07-26 00:00:00,2018-08-24 20:49:05 | ||
2984,FALSE,2020-01-15 0:03:02,FALSE,0,,4003,,2018-08-29 16:45:04,USD,,599,,1,211,NotSet,,,,,,NeedToPrint,,0,,4259,2,3591,0,2018-07-25 00:00:00,2018-10-29 14:54:47 | ||
2986,FALSE,2020-01-15 0:03:02,FALSE,0,,4003,,2018-08-29 16:46:08,USD,,599,,1,212,NotSet,,,,,,NeedToPrint,,0,,4259,1,60522,0,2018-08-13 00:00:00,2018-08-29 16:46:19 | ||
3072,FALSE,2020-01-15 0:03:02,FALSE,0,,155,,2018-08-31 17:52:46,USD,,672,,1,214,NotSet,,,,,,NeedToPrint,,0,,557,1,17649,0,2018-08-28 00:00:00,2018-08-31 17:53:41 | ||
3089,FALSE,2020-01-15 0:03:02,FALSE,0,d41d8cd98f00b204e9800998ecf8427e,154,,2018-09-06 14:47:55,USD,,671,,1,215,NotSet,,,,,,NeedToPrint,,0,,154,1,16638,0,2018-07-20 00:00:00,2018-09-06 14:48:27 | ||
3093,FALSE,2020-01-15 0:03:02,FALSE,0,,131,,2018-09-06 17:14:05,USD,,593,,1,216,NotSet,,,,,,NeedToPrint,,0,,131,1,84675,0,2018-08-28 00:00:00,2018-09-06 17:14:34 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
id,_fivetran_deleted,_fivetran_synced,accepted_by,accepted_date,apply_tax_after_discount,bill_email,billing_address_id,class_id,created_at,currency_id,custom_p_o_number,custom_sales_rep,customer_id,customer_memo,delivery_type,department_id,doc_number,due_date,email_status,exchange_rate,expiration_date,global_tax_calculation,home_total_amount,print_status,private_note,sales_term_id,ship_date,shipping_address_id,sync_token,tax_code_id,total_amount,total_tax,transaction_date,transaction_status,updated_at | ||
40085,FALSE,2021-01-19 0:16:33,,,FALSE,,7161,,2021-01-18 23:34:30,USD,,,4953,6daa548b66caa8322851e9ac8fdbe270,,,2552,,NotSet,,,,,NeedToPrint,,,,7162,1,,29690,0,2021-01-18 0:00:00,Accepted,2021-01-18 23:35:13 | ||
40087,FALSE,2021-01-19 0:16:33,,,FALSE,,7512,,2021-01-18 23:54:01,USD,,,5073,6daa548b66caa8322851e9ac8fdbe270,,,2553,,NotSet,,,,,NeedToPrint,,,,7513,1,,77282,0,2021-01-18 0:00:00,Accepted,2021-01-18 23:54:24 | ||
40079,FALSE,2021-01-18 23:16:15,,,FALSE,,7617,,2021-01-18 23:09:42,USD,,,5121,6daa548b66caa8322851e9ac8fdbe270,,,2549,,NotSet,,,,,NeedToPrint,,,,7618,1,,26564,0,2021-01-18 0:00:00,Accepted,2021-01-18 23:10:33 | ||
40091,FALSE,2021-01-19 0:16:33,,,FALSE,,6923,,2021-01-19 0:11:28,USD,,,4895,6daa548b66caa8322851e9ac8fdbe270,,,2555,,NotSet,,,,,NeedToPrint,,,,6924,1,,34363.5,0,2021-01-18 0:00:00,Accepted,2021-01-19 0:11:49 | ||
40083,FALSE,2021-01-19 0:16:33,,,FALSE,,6131,,2021-01-18 23:22:28,USD,,,4547,6daa548b66caa8322851e9ac8fdbe270,,,2551,,NotSet,,,,,NeedToPrint,,,,6132,1,,32645,0,2021-01-18 0:00:00,Accepted,2021-01-18 23:23:19 | ||
40081,FALSE,2021-01-19 0:16:33,,,FALSE,,7740,,2021-01-18 23:15:52,USD,,,4132,6daa548b66caa8322851e9ac8fdbe270,,,2550,,NotSet,,,,,NeedToPrint,,,,5150,1,,28760,0,2021-01-18 0:00:00,Accepted,2021-01-18 23:16:15 | ||
40089,FALSE,2021-01-19 0:16:33,,,FALSE,bc5b17e4502ad6537ccdcf066e03bda7,2825,,2021-01-19 0:05:10,USD,,,3226,6daa548b66caa8322851e9ac8fdbe270,,,2554,,NotSet,,,,,NeedToPrint,,,,2826,1,,49442,0,2021-01-18 0:00:00,Accepted,2021-01-19 0:05:37 | ||
40095,FALSE,2021-01-19 1:18:11,,,FALSE,,6913,,2021-01-19 0:43:48,USD,,,4892,6daa548b66caa8322851e9ac8fdbe270,,,2557,,NotSet,,,,,NeedToPrint,,,,6914,1,,27832,0,2021-01-18 0:00:00,Accepted,2021-01-19 0:44:50 | ||
40093,FALSE,2021-01-19 1:18:11,,,FALSE,,6106,,2021-01-19 0:24:12,USD,,,4536,6daa548b66caa8322851e9ac8fdbe270,,,2556,,NotSet,,,,,NeedToPrint,,,,6107,1,,56661.5,0,2021-01-18 0:00:00,Accepted,2021-01-19 0:30:18 | ||
40112,FALSE,2021-01-19 21:16:21,,,FALSE,,6594,,2021-01-19 20:49:07,USD,,,4783,6daa548b66caa8322851e9ac8fdbe270,,,2558,,NotSet,,,,,NeedToPrint,,,,6595,1,,56321,0,2021-01-19 0:00:00,Accepted,2021-01-19 20:51:03 | ||
40085,FALSE,2021-01-19 0:16:33,,,FALSE,,7161,,2021-01-18 23:34:30,USD,,,4953,6daa548b66caa8322851e9ac8fdbe270,,,2552,,NotSet,,,,,NeedToPrint,,,,7162,1,,29690,0,2021-01-18 00:00:00,Accepted,2021-01-18 23:35:13 | ||
40087,FALSE,2021-01-19 0:16:33,,,FALSE,,7512,,2021-01-18 23:54:01,USD,,,5073,6daa548b66caa8322851e9ac8fdbe270,,,2553,,NotSet,,,,,NeedToPrint,,,,7513,1,,77282,0,2021-01-18 00:00:00,Accepted,2021-01-18 23:54:24 | ||
40079,FALSE,2021-01-18 23:16:15,,,FALSE,,7617,,2021-01-18 23:09:42,USD,,,5121,6daa548b66caa8322851e9ac8fdbe270,,,2549,,NotSet,,,,,NeedToPrint,,,,7618,1,,26564,0,2021-01-18 00:00:00,Accepted,2021-01-18 23:10:33 | ||
40091,FALSE,2021-01-19 0:16:33,,,FALSE,,6923,,2021-01-19 0:11:28,USD,,,4895,6daa548b66caa8322851e9ac8fdbe270,,,2555,,NotSet,,,,,NeedToPrint,,,,6924,1,,34363.5,0,2021-01-18 00:00:00,Accepted,2021-01-19 0:11:49 | ||
40083,FALSE,2021-01-19 0:16:33,,,FALSE,,6131,,2021-01-18 23:22:28,USD,,,4547,6daa548b66caa8322851e9ac8fdbe270,,,2551,,NotSet,,,,,NeedToPrint,,,,6132,1,,32645,0,2021-01-18 00:00:00,Accepted,2021-01-18 23:23:19 | ||
40081,FALSE,2021-01-19 0:16:33,,,FALSE,,7740,,2021-01-18 23:15:52,USD,,,4132,6daa548b66caa8322851e9ac8fdbe270,,,2550,,NotSet,,,,,NeedToPrint,,,,5150,1,,28760,0,2021-01-18 00:00:00,Accepted,2021-01-18 23:16:15 | ||
40089,FALSE,2021-01-19 0:16:33,,,FALSE,bc5b17e4502ad6537ccdcf066e03bda7,2825,,2021-01-19 0:05:10,USD,,,3226,6daa548b66caa8322851e9ac8fdbe270,,,2554,,NotSet,,,,,NeedToPrint,,,,2826,1,,49442,0,2021-01-18 00:00:00,Accepted,2021-01-19 0:05:37 | ||
40095,FALSE,2021-01-19 1:18:11,,,FALSE,,6913,,2021-01-19 0:43:48,USD,,,4892,6daa548b66caa8322851e9ac8fdbe270,,,2557,,NotSet,,,,,NeedToPrint,,,,6914,1,,27832,0,2021-01-18 00:00:00,Accepted,2021-01-19 0:44:50 | ||
40093,FALSE,2021-01-19 1:18:11,,,FALSE,,6106,,2021-01-19 0:24:12,USD,,,4536,6daa548b66caa8322851e9ac8fdbe270,,,2556,,NotSet,,,,,NeedToPrint,,,,6107,1,,56661.5,0,2021-01-18 00:00:00,Accepted,2021-01-19 0:30:18 | ||
40112,FALSE,2021-01-19 21:16:21,,,FALSE,,6594,,2021-01-19 20:49:07,USD,,,4783,6daa548b66caa8322851e9ac8fdbe270,,,2558,,NotSet,,,,,NeedToPrint,,,,6595,1,,56321,0,2021-01-19 00:00:00,Accepted,2021-01-19 20:51:03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli Since we're not cutting a new release, would recommend making this like
dbt_quickbooks v0.VERSION.VERSION
since the next release could go to 0.11.2 or 0.12.0.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good point, it'll serve as a good reminder as well. updated!