PR fixes

fivetran · Nov 21, 2024 · c65bad5 · c65bad5
2 parents 9ab70d3 + c0ca2ea
commit c65bad5
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,12 +1,12 @@
 # dbt_quickbooks v0.17.0
 [PR #146](https://github.com/fivetran/dbt_quickbooks/pull/146) introduces the following updates:
 
-## Feature Updates
+## Breaking Changes
 - We have introduced the following fields in the `quickbooks__general_ledger` to better analyze real-time transaction data:
   - `created_at`: The time a transaction was first created.
   - `updated_at`: The time a transaction was last updated.
-  - This required updates to all our double entry transaction models to bring in these specific fields for each transaction type. 
-- This isn't necessarily a breaking change, but as this introduces new fields to an end model, we determined it was best to bump the version up.
+  - This required updates to all our double entry transaction models to bring in these specific fields for each transaction type.
+- This is a breaking change as this adds new fields to the existing schema for one of our end models. 
 
 # dbt_quickbooks v0.16.0
 [PR #143](https://github.com/fivetran/dbt_quickbooks/pull/143) introduces the following updates:

diff --git a/README.md b/README.md
@@ -226,7 +226,7 @@ This dbt package is dependent on the following dbt packages. These dependencies
 ```yml
 packages:
     - package: fivetran/quickbooks_source
-      version: [">=0.11.0", "<0.12.0"]
+      version: [">=0.12.0", "<0.13.0"]
 
     - package: fivetran/fivetran_utils
       version: [">=0.4.0", "<0.5.0"]

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -6,18 +6,6 @@ profile: 'integration_tests'
 config-version: 2
 models:
   +schema: "quickbooks_{{ var('directed_schema','dev') }}"
-  quickbooks:
-    +materialized: table
-    double_entry_transactions:
-      +materialized: table
-    transaction_lines:
-      +materialized: table
-    intermediate:
-      +materialized: table
-  quickbooks_source:
-    +materialized: table
-    tmp:
-      +materialized: view
 
 vars:
   quickbooks_source:

diff --git a/models/intermediate/int_quickbooks__retained_earnings.sql b/models/intermediate/int_quickbooks__retained_earnings.sql
@@ -40,7 +40,6 @@ net_income_loss as (
     join expense_starter 
         using (period_first_day, source_relation)
 ),
-
 retained_earnings_starter as (
 
     select
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,6 @@ net_income_loss as ( @@
         join expense_starter
             using (period_first_day, source_relation)
     ),
     retained_earnings_starter as (
         select
@@ Expand Down @@