Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sspecacct field to stg_netsuite2__accounts table #40

Conversation

jmongerlyra
Copy link
Contributor

Please provide your name and company
Jared Monger, Lyra Health

Link the issue/feature request which this PR is meant to address
fivetran/dbt_netsuite#89

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
sspecacct is required in the source data in order to properly classify transactions recorded directly to CTA and Retained Earnings GL accounts. See related PR. fivetran/dbt_netsuite#90

How did you validate the changes introduced within this PR?
Lyra forked the repo and implemented/validated the changes against NetSuite reporting.

Which warehouse did you use to develop these changes?
Snowflake

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmongerlyra this update looks good to me and will be valuable to use in your transforms PR. While I am holding off on merging your transform PR until we have time to review it, I don't see an issue with incorporating this updating into our upcoming release.

I will merge this into my working branch and this should be available by default in the upcoming netsuite_source release.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to feature/account-eliminate-field-add October 17, 2023 18:26
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit d7dd4c8 into fivetran:feature/account-eliminate-field-add Oct 17, 2023
@jmongerlyra jmongerlyra deleted the lyra_fixes branch October 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants