Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databricks #61

Merged
merged 4 commits into from
Feb 2, 2023
Merged

databricks #61

merged 4 commits into from
Feb 2, 2023

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Feb 1, 2023

Are you a current Fivetran customer?

fivetran made pr
What change(s) does this PR introduce?

ensures databricks compatibility. no code changes were required in the transform package, but make sure fivetran/dbt_fivetran_utils#98 is merged first

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🧱

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie fivetran-jamie self-assigned this Feb 1, 2023
@fivetran-jamie fivetran-jamie added type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality labels Feb 1, 2023
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie Mostly good! Some changes but mostly syntax.

README.md Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
packages.yml Show resolved Hide resolved
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie fivetran-jamie changed the base branch from main to releases/v0.7.latest February 2, 2023 18:57
@fivetran-jamie fivetran-jamie merged commit b76db75 into releases/v0.7.latest Feb 2, 2023
@fivetran-jamie fivetran-jamie mentioned this pull request Feb 2, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants