Bug/last modified at

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature:

• [Bug] constant expressions are not supported in partition by clauses in Redshift due to linkedin_ads_source.stg_linkedin_ads__creative_history dbt_linkedin#33

This PR will result in the following new package version:

• v0.8.2
• made a patch since this is fixing a data quality issue

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

• Updated the determination of the columns is_latest_version, last_modified_at, status, and created_at for model stg_linkedin_ads__creative_history to accommodate Fivetran connectors that existed prior to the January 2023 Fivetran connector update.
  • Specifically for these connectors, the new source last_modified_at field was retroactively filled with a default value of 1970-01-01 instead of null values. Consequently, the coalesce of line 35 could only use the value from last_modified_at. To address this, we have adjusted the coalesce order to prioritize the previous last_modified_time and prevent it from being overridden by the default values mentioned for columns is_latest_version and last_modified_at.
  • Updated the coalesce order for determining status and created_at for consistency.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned.
• All necessary documentation and version upgrades have been applied.
• docs were regenerated (unless this PR does not include any code or yml updates).
• BuildKite integration tests are passing.
• Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

• Confirmed the correct values are brought into last_modified_at.
• Worked with customer to verify on their end.
• See internal ticket for validation sheet.

If you had to summarize this PR in an emoji, which would it be?

🎡

[fivetran-joemarkiewicz]

@fivetran-catfritz thanks for working through this update and validating the issue and fix with the customer! I do have two small comments to be addressed before this will be good to be approved. Let me know if you have any questions. Thanks!

[fivetran-joemarkiewicz]

Thanks for applying the requested changes! Following your updates and after inspecting the validations you provided, this looks good to go!