Skip to content

Commit

Permalink
feature/click-uri-updates (#38)
Browse files Browse the repository at this point in the history
* feature/click-uri-updates

* additional changes

* changelog update and docs regen

* regen docs

* Update CHANGELOG.md

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

* Update packages.yml

---------

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
  • Loading branch information
fivetran-joemarkiewicz and fivetran-avinash authored Dec 16, 2024
1 parent 42acae1 commit 15e32ce
Show file tree
Hide file tree
Showing 14 changed files with 156 additions and 126 deletions.
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
# dbt_linkedin v0.10.0
[PR #38](https://github.com/fivetran/dbt_linkedin/pull/38) includes the following updates:

## Breaking Changes
- The `click_uri_type` field has been added to the below mentioned models. This field allows users to differentiate which click uri type (`text_ad` or `spotlight`) is being used to populate the results of the `click_uri` field. Please be aware this field only supports `text_ad` or `spotlight` click uri types. If you are interested in this package supporting more click uri ad types, please let us know in this [Feature Request](https://github.com/fivetran/dbt_linkedin_source/issues/70).
- `stg_linkedin_ads__creative_history` (in the `dbt_linkedin_source` package)
- `linkedin_ads__creative_report`
- `linkedin_ads__url_report`

## Bug Fixes (upstream dbt_linkedin_source change)
- The `click_uri` field has been adjusted to populate the results following a coalesce on the `text_ad_landing_page`, `spotlight_landing_page`, or `click_uri` fields. For more details refer to [dbt_linkedin_source v0.10.0](https://github.com/fivetran/dbt_linkedin_source/releases/tag/v0.10.0) release notes.
- This change is in response to a [LinkedIn Ads API](https://learn.microsoft.com/en-us/linkedin/marketing/community-management/contentapi-migration-guide?view=li-lms-2024-05#adcreativesv2-api-creatives-api) and [Fivetran LinkedIn Ads connector update](https://fivetran.com/docs/connectors/applications/linkedin-ads/changelog#january2024) which moved `click_uri` data to either the `text_ad_landing_page` or `spotlight_landing_page` fields depending on the creative type.

## Documentation Updates
- The `click_uri` field documentation has been updated to reflect the updated state of the field.
- Included a new `DECISIONLOG.md` entry to highlight why it's possible metrics don't add up across different grains.

## Under the Hood
- Updates to the `linkedin_creative_history_data` seed file to include the following new fields to ensure accurate data validation tests:
- `text_ad_landing_page`
- `spotlight_landing_page`

# dbt_linkedin v0.9.1
[PR #41](https://github.com/fivetran/dbt_linkedin/pull/41) includes the following updates:

Expand Down
7 changes: 6 additions & 1 deletion DECISIONLOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,9 @@ vars:
linkedin_ads__conversion_fields: ['external_website_pre_click_conversions', 'external_website_post_click_conversions']
```

`external_website_pre_click_conversions` and `external_website_post_click_conversions` are two different type of external website conversions, so there should be no overlap.
`external_website_pre_click_conversions` and `external_website_post_click_conversions` are two different type of external website conversions, so there should be no overlap.

## Why don't metrics add up across different grains (Ex. ad level vs campaign level)?
Not all ads are served at the ad level. Some are delivered only at higher levels like the ad group or campaign. As a result, metrics like spend may differ across levels since not all ads are captured in ad-level reports.

To ensure data completeness, we separate reporting into hierarchical models (Ad, Ad Group, Campaign, etc.). Relying solely on ad-level reports could result in missing data from other levels.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Include the following Linkedin Ads package version in your `packages.yml` file:
# packages.yml
packages:
- package: fivetran/linkedin
version: [">=0.9.0", "<0.10.0"]
version: [">=0.10.0", "<0.11.0"]
```
Do **NOT** include the `linkedin_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well.

Expand Down Expand Up @@ -167,7 +167,7 @@ This dbt package is dependent on the following dbt packages. These dependencies
```yml
packages:
- package: fivetran/linkedin_source
version: [">=0.9.0", "<0.10.0"]
version: [">=0.10.0", "<0.11.0"]
- package: fivetran/fivetran_utils
version: [">=0.4.0", "<0.5.0"]
- package: dbt-labs/dbt_utils
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'linkedin'
version: '0.9.1'
version: '0.10.0'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
vars:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion docs/run_results.json

This file was deleted.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'linkedin_integration_tests'
version: '0.9.1'
version: '0.10.0'
profile: 'integration_tests'
config-version: 2

Expand Down
202 changes: 101 additions & 101 deletions integration_tests/seeds/linkedin_creative_history_data.csv
Original file line number Diff line number Diff line change
@@ -1,101 +1,101 @@
id,last_modified_at,created_at,campaign_id,intended_status,click_uri
112590914,2020-07-01 00:32:56,2018-05-24 00:38:47,131580446,CANCELED,https://google.com
95761876,2020-07-01 00:32:56,2018-05-18 01:04:02,131454616,CANCELED,
102318493,2020-09-10 18:29:16,2020-09-10 18:08:57,167276694,ACTIVE,
95761676,2020-07-27 15:19:33,2020-07-22 19:28:31,165867684,ACTIVE,
104230363,2020-07-22 19:28:31,2020-07-22 19:28:31,165867684,DRAFT,
112600554,2020-05-08 11:37:43,2020-05-08 09:34:15,162464924,ACTIVE,
95763356,2020-05-12 15:39:25,2020-05-12 14:08:40,162557074,ACTIVE,
70668606,2020-07-01 00:32:56,2018-05-18 01:09:08,131454826,CANCELED,
69776656,2020-03-23 14:52:29,2020-03-20 18:55:40,148633856,ACTIVE,
70668676,2020-07-01 00:32:56,2018-05-24 00:47:40,131580546,CANCELED,
44900346,2020-03-24 18:05:27,2020-03-24 17:56:49,148711996,ACTIVE,
81968486,2018-02-12 10:09:41,2017-06-08 21:46:06,125600246,ACTIVE,
70668676,2018-02-12 10:09:19,2017-06-08 21:46:06,125600246,ACTIVE,
81968486,2018-02-12 10:09:56,2017-06-08 21:46:06,125600246,ACTIVE,
82056746,2018-02-12 10:09:27,2017-06-08 21:46:06,125600246,ACTIVE,
44900356,2020-07-23 17:22:59,2017-08-04 22:45:09,133160324,PAUSED,
70669876,2018-05-11 12:38:59,2017-08-04 22:45:09,133160324,ACTIVE,
84578906,2018-02-12 10:22:30,2017-06-08 22:29:09,125599426,ACTIVE,
80494806,2018-02-12 10:22:34,2017-06-08 22:29:09,125599426,ACTIVE,
84909276,2018-05-11 12:38:59,2017-08-04 22:45:09,133160324,ACTIVE,
76339806,2018-02-12 10:22:39,2017-06-08 22:29:09,125599426,ACTIVE,
82056546,2018-05-11 12:38:59,2017-08-04 22:45:09,133160324,ACTIVE,
44901886,2018-05-11 12:38:59,2017-08-04 22:45:09,133160324,ACTIVE,
70668856,2018-02-12 10:22:43,2017-06-08 22:29:09,125599426,ACTIVE,
84594916,2018-08-07 15:13:09,2017-10-10 16:49:38,127624356,PAUSED,
70668676,2018-08-31 20:21:58,2017-10-10 16:49:38,127624356,PAUSED,
44900366,2018-08-31 20:21:56,2017-10-10 16:49:38,127624356,PAUSED,
80494706,2018-04-19 01:01:41,2017-12-22 17:38:12,128806186,ACTIVE,
44901876,2018-04-20 16:09:25,2017-12-22 17:27:45,128806016,ACTIVE,
81968566,2018-04-20 20:54:43,2017-12-22 17:38:12,128806186,ACTIVE,
44900356,2018-04-20 20:54:36,2017-12-22 17:27:45,128806016,ACTIVE,
84897806,2018-07-28 18:42:52,2018-07-25 15:04:05,132822186,PAUSED,
70669876,2018-07-28 18:57:01,2018-07-28 18:48:26,132870856,ACTIVE,
44900336,2018-07-28 18:44:22,2018-07-28 18:38:10,132866546,ARCHIVED,
44900356,2018-09-10 23:06:50,2018-09-06 16:59:15,133672706,ACTIVE,
102326993,2018-09-10 17:55:24,2018-09-10 17:52:28,133728466,ACTIVE,
111449024,2018-09-10 23:18:06,2018-09-10 23:16:13,133736786,ACTIVE,
109754844,2018-09-13 18:01:26,2018-09-13 17:59:19,133822116,ACTIVE,
111024974,2018-10-08 17:51:55,2018-10-08 17:49:29,134383046,ACTIVE,
103117663,2018-10-08 17:55:09,2018-10-08 17:54:17,134383176,ACTIVE,
107328744,2018-11-14 21:16:03,2018-10-31 17:30:40,134988516,ACTIVE,
95763826,2018-11-23 12:57:25,2018-11-21 17:08:53,135583676,ACTIVE,
94954376,2018-12-10 18:03:37,2018-12-10 18:01:42,136022286,ACTIVE,
95762316,2019-01-08 17:52:12,2019-01-08 17:27:32,136508426,ACTIVE,
44900366,2019-01-08 18:00:10,2019-01-08 17:57:44,136509566,ACTIVE,
83878136,2019-01-11 21:06:51,2019-01-11 21:00:57,136598756,ACTIVE,
70668606,2019-01-17 22:39:37,2019-01-17 19:19:05,136746346,ACTIVE,
44900336,2019-02-20 23:02:25,2019-02-20 17:23:30,137527956,ACTIVE,
84092676,2019-02-21 17:53:26,2019-02-21 17:46:17,137559956,ACTIVE,
70668856,2019-03-04 19:37:29,2019-03-04 19:12:56,137824786,ACTIVE,
70668306,2019-04-29 17:21:39,2019-04-29 17:20:56,139304236,ACTIVE,
69775486,2019-04-29 17:45:59,2019-04-29 17:32:14,139304466,ACTIVE,
69776656,2019-05-08 18:31:04,2019-05-08 17:34:16,139548496,ACTIVE,
48046336,2019-05-09 15:47:39,2019-05-09 15:19:05,139581266,ACTIVE,
55220314,2019-05-10 19:24:18,2019-05-10 16:05:30,139619466,ACTIVE,
44900356,2019-05-17 16:53:00,2019-05-17 14:50:20,139812856,ACTIVE,
82056656,2019-06-03 20:44:36,2019-06-03 19:34:54,140203726,ACTIVE,
44900356,2019-06-03 20:59:59,2019-06-03 20:59:46,140206956,ACTIVE,
44901856,2019-06-14 17:17:25,2019-06-14 17:17:18,140506806,ACTIVE,
70668676,2019-07-01 20:07:24,2019-06-21 18:33:19,140715576,PAUSED,
48046326,2019-07-08 15:39:00,2019-07-08 15:16:08,141092076,ACTIVE,
70668606,2019-07-29 15:16:22,2019-07-08 15:13:19,141091746,ACTIVE,
70669236,2019-07-08 15:24:28,2019-07-08 15:24:18,141092526,ACTIVE,
81968586,2019-07-08 15:29:26,2019-07-08 15:29:15,141092656,ACTIVE,
55220334,2019-07-18 15:40:35,2019-07-18 15:40:03,141360566,ACTIVE,
70669876,2019-07-29 18:33:07,2019-07-29 18:33:05,141360566,ACTIVE,
48046336,2019-07-29 18:36:00,2019-07-29 18:35:50,141360566,ACTIVE,
44901866,2019-07-29 18:45:38,2019-07-29 18:37:21,141360566,ACTIVE,
55220314,2019-09-02 12:50:44,2019-07-29 18:40:24,141091746,ACTIVE,
70668606,2019-07-29 18:41:56,2019-07-29 18:41:41,141091746,ACTIVE,
69776656,2019-07-29 18:43:33,2019-07-29 18:43:04,141091746,ACTIVE,
44901866,2019-07-29 18:46:44,2019-07-29 18:46:41,141092526,ACTIVE,
48046336,2019-07-29 18:48:14,2019-07-29 18:48:12,141092526,ACTIVE,
76339806,2019-07-29 18:52:40,2019-07-29 18:52:24,141092526,ACTIVE,
107427114,2019-07-29 18:53:31,2019-07-29 18:53:27,141092656,ACTIVE,
107780874,2019-07-29 18:55:06,2019-07-29 18:54:42,141092656,ACTIVE,
103860724,2019-07-29 19:08:42,2019-07-29 19:08:28,141092656,ACTIVE,
94336026,2019-09-06 17:06:44,2019-09-06 16:54:36,142718926,ACTIVE,
109331754,2019-09-07 01:31:08,2019-09-06 18:47:11,142723626,ACTIVE,
107328014,2019-09-12 16:49:10,2019-09-12 16:48:25,142886156,ACTIVE,
107426034,2019-10-30 17:48:33,2019-10-30 17:47:59,144266096,ACTIVE,
107426034,2019-10-30 18:28:54,2019-10-30 18:28:17,144267636,ACTIVE,
104229493,2019-11-06 18:15:13,2019-11-06 18:14:42,144486446,ACTIVE,
104230513,2019-11-14 15:59:08,2019-11-14 15:58:40,144730056,ACTIVE,
109947744,2019-12-18 17:06:17,2019-12-18 16:13:57,146251416,ACTIVE,
104229703,2019-12-19 16:59:51,2019-12-19 15:42:00,146251626,ACTIVE,
112487464,2020-01-07 19:05:55,2020-01-07 19:05:17,146537336,ACTIVE,
70669876,2020-02-03 20:11:30,2020-02-03 20:10:59,147221246,ACTIVE,
44901856,2020-03-26 20:37:26,2020-03-26 20:37:02,148790486,ACTIVE,
44901886,2020-03-26 20:38:13,2020-03-26 20:37:44,148790536,ACTIVE,
80494736,2020-03-26 20:38:58,2020-03-26 20:38:25,148790586,ACTIVE,
44901866,2020-04-07 15:12:31,2020-04-07 15:10:41,149101206,ACTIVE,
44901856,2020-04-07 18:49:47,2020-04-07 15:24:12,149101696,ACTIVE,
81708396,2020-04-07 15:32:09,2020-04-07 15:31:39,149102126,ACTIVE,
60400066,2020-06-01 15:53:04,2020-04-28 15:27:36,149834446,PAUSED,
44901866,2020-05-26 11:11:58,2020-05-26 11:09:20,162905364,ACTIVE,
44900346,2020-08-21 21:15:10,2020-08-21 21:14:46,166816004,ACTIVE,
70669196,2020-08-21 21:15:47,2020-08-21 21:15:23,166816034,ACTIVE,
55220314,2020-08-21 21:16:11,2020-08-21 21:15:59,166816044,ACTIVE,
48046336,2020-08-21 21:17:17,2020-08-21 21:17:13,166816094,ACTIVE,
id,campaign_id,intended_status,click_uri,last_modified_at,created_time,text_ad_landing_page,spotlight_landing_page
125339904,174942134,,,,2021-03-08 23:42:20,,"http://www.linkedin.com"
186286604,202434464,,,,2022-09-16 02:46:54,,"http://www.linkedin.com"
54106906,131454616,,,,2018-05-18 01:04:02,,"http://www.linkedin.com"
54106976,131454826,,,,2018-05-18 01:09:08,,"http://www.linkedin.com"
54299976,131580446,,,,2018-05-24 00:38:47,,"http://www.linkedin.com"
54300176,131580546,,,,2018-05-24 00:47:40,,"http://www.linkedin.com"
82332766,148633856,,,,2020-03-20 18:55:40,,"http://www.linkedin.com"
82460426,148711996,,,,2020-03-24 17:56:49,,"http://www.linkedin.com"
102541764,162464924,,,,2020-05-08 09:34:15,,"http://www.linkedin.com"
102694624,162557074,,,,2020-05-12 14:08:40,,"http://www.linkedin.com"
107943663,165867684,,,,2020-07-22 19:28:31,,"http://www.linkedin.com"
110663234,167276694,,,,2020-09-10 18:08:57,,"http://www.linkedin.com"
44900356,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900356,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900356,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900356,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900336,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900336,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900336,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900336,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900366,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900366,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900366,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900366,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900346,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900346,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900346,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
44900346,125600246,,,,2017-06-08 21:46:06,,"http://www.linkedin.com"
55220334,133160324,,,,2017-08-04 22:45:09,,"http://www.linkedin.com"
55220334,133160324,,,,2017-08-04 22:45:09,,"http://www.linkedin.com"
44901856,125599426,,,,2017-06-08 22:29:09,,"http://www.linkedin.com"
55220334,133160324,,,,2017-08-04 22:45:09,,"http://www.linkedin.com"
44901856,125599426,,,,2017-06-08 22:29:09,,"http://www.linkedin.com"
44901856,125599426,,,,2017-06-08 22:29:09,,"http://www.linkedin.com"
44901866,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
44901866,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
44901866,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
55220324,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
55220324,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
55220324,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
44901876,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
55220314,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
44901876,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
55220314,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
55220314,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
44901876,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
44901876,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
55220314,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
55220304,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
44901886,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
44901886,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
44901886,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
55220304,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
55220304,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
55220304,133160324,,,,2017-08-04 22:45:09,"http://www.google.com",
44901886,125599426,,,,2017-06-08 22:29:09,"http://www.google.com",
48046336,127624356,,,,2017-10-10 16:49:38,"http://www.google.com",
48046326,127624356,,,,2017-10-10 16:49:38,"http://www.google.com",
48046346,127624356,,,,2017-10-10 16:49:38,"http://www.google.com",
50036216,128806186,,,,2017-12-22 17:38:12,"http://www.google.com",
50035816,128806016,,,,2017-12-22 17:27:45,"http://www.google.com",
50036226,128806186,,,,2017-12-22 17:38:12,"http://www.google.com",
50035806,128806016,,,,2017-12-22 17:27:45,"http://www.google.com",
56166306,132822186,,,,2018-07-25 15:04:05,"http://www.google.com",
56166306,132822186,,,,2018-07-25 15:04:05,"http://www.google.com",
56166306,132822186,,,,2018-07-25 15:04:05,"http://www.google.com",
56237466,132870856,,,,2018-07-28 18:48:26,"http://www.google.com",
56237376,132866546,,,,2018-07-28 18:38:10,"http://www.google.com",
57434376,133672706,,,,2018-09-06 16:59:15,"http://www.google.com",
57527536,133728466,,,,2018-09-10 17:52:28,"http://www.google.com",
57542836,133736786,,,,2018-09-10 23:16:13,"http://www.google.com",
57675346,133822116,,"http://www.github.com",,2018-09-13 17:59:19,,
58503736,134383046,,"http://www.github.com",,2018-10-08 17:49:29,,
58503856,134383176,,"http://www.github.com",,2018-10-08 17:54:17,,
59428846,134988516,,"http://www.github.com",,2018-10-31 17:30:40,,
60400066,135583676,,"http://www.github.com",,2018-11-21 17:08:53,,
61088626,136022286,,"http://www.github.com",,2018-12-10 18:01:42,,
61884186,136508426,,"http://www.github.com",,2019-01-08 17:27:32,,
61885366,136509566,,"http://www.github.com",,2019-01-08 17:57:44,,
62024726,136598756,,"http://www.github.com",,2019-01-11 21:00:57,,
62257986,136746346,,"http://www.github.com",,2019-01-17 19:19:05,,
63506906,137527956,,"http://www.github.com",,2019-02-20 17:23:30,,
63556186,137559956,,"http://www.github.com",,2019-02-21 17:46:17,,
64024086,137824786,,"http://www.github.com",,2019-03-04 19:12:56,,
66558706,139304236,,"http://www.github.com",,2019-04-29 17:20:56,,
66559306,139304466,,"http://www.github.com",,2019-04-29 17:32:14,,
66980846,139548496,,"http://www.github.com",,2019-05-08 17:34:16,,
67039296,139581266,,"http://www.github.com",,2019-05-09 15:19:05,,
67131396,139619466,,"http://www.github.com",,2019-05-10 16:05:30,,
67495816,139812856,,"http://www.github.com",,2019-05-17 14:50:20,,
68192386,140203726,,"http://www.github.com",,2019-06-03 19:34:54,,
68197356,140206956,,"http://www.github.com",,2019-06-03 20:59:46,,
68755776,140506806,,"http://www.github.com",,2019-06-14 17:17:18,,
69108056,140715576,,"http://www.github.com",,2019-06-21 18:33:19,,
69775776,141092076,,"http://www.github.com",,2019-07-08 15:16:08,,
69775486,141091746,,"http://www.github.com",,2019-07-08 15:13:19,,
69776656,141092526,,"http://www.github.com",,2019-07-08 15:24:18,,
69777076,141092656,,"http://www.github.com",,2019-07-08 15:29:15,,
70247496,141360566,,"http://www.github.com",,2019-07-18 15:40:03,,
70668196,141360566,,"http://www.github.com",,2019-07-29 18:33:05,,
14 changes: 8 additions & 6 deletions models/linkedin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,10 @@ models:
CANCELED - Creative is permanently canceled.
- name: click_uri
description: |
Required when creative type is TEXT_AD. Maximum character limit of 500 after URL encoding all special characters.
Limit does not include the "https://" prefix.
description: The URL where the member should be redirected to, on clicking the text ad or spotlight ad.

- name: click_uri_type
description: Will either be `text_ad`, `spotlight`, or `null` to indicate the origin of the click_uri.

- name: campaign_group_status
description: >
Expand Down Expand Up @@ -480,15 +481,16 @@ models:
- not_null

- name: click_uri
description: |
Required when creative type is TEXT_AD. Maximum character limit of 500 after URL encoding all special characters.
Limit does not include the "https://" prefix.
description: The URL where the member should be redirected to, on clicking the text ad or spotlight ad.
tests:
- not_null:
config:
# Below is so we don't run this test if the user has allowed urls to have null entries
enabled: "{{ var('ad_reporting__url_report__using_null_filter', true) }}"

- name: click_uri_type
description: Will either be `text_ad`, `spotlight`, or `null` to indicate the origin of the click_uri.

- name: base_url
description: The base URL of the ad, extracted from the `click_uri`.

Expand Down
3 changes: 2 additions & 1 deletion models/linkedin_ads__creative_report.sql
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ final as (
account.account_id,
account.account_name,
creative.click_uri,
creative.click_uri_type,
creative.status as creative_status,
campaign.status as campaign_status,
campaign_group.status as campaign_group_status,
Expand Down Expand Up @@ -82,7 +83,7 @@ final as (
on campaign.account_id = account.account_id
and campaign.source_relation = account.source_relation

{{ dbt_utils.group_by(16) }}
{{ dbt_utils.group_by(17) }}

)

Expand Down
Loading

0 comments on commit 15e32ce

Please sign in to comment.