Feature/package updates #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/dbt_lever into feature/package_updates
fivetran-joemarkiewicz
approved these changes
May 18, 2022
There was a problem hiding this comment.
@fivetran-reneeli I know CircleCi is failing, but I think it is due to the packages.yml. I did a review and have a few suggestions that should be applied before merging.
- CHANGELOG suggested change
- A few README updates including updating the links to the final models
- Updating the packages.yml. I believe this is what is necessary to pass the tests. But be sure to switch before merging.
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
…/dbt_lever into feature/package_updates
There was a problem hiding this comment.
Ignore. Meaning to submit a review to the Salesforce branch and was comparing it to changes made on this Lever PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Internal
What change(s) does this PR introduce?
We are applying standardization updates to be more consistent in our documentation.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
This won't be necessarily be breaking, but this will be a major change to the look and feel of our package.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
📚 :
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.