bug/add-disable-teams #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 30, 2023
fivetran-sheringuyen
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Hey @fivetran-catfritz ! Good job on this PR. I only left one minor suggestion in the CHANGELOG but otherwise, PR looks good an I have approved it.
CHANGELOG.md
Outdated
| ## 🚨 Breaking Change 🚨 | ||
| - Expanded the variable `github__using_repo_team` to also toggle on/off the `TEAM` table along with and in addition to the `REPO_TEAM` table. This was done to fix issues with dependent models in our transform package, where `TEAM` is only ever used in conjunction with `REPO_TEAM`. ([#32](https://github.com/fivetran/dbt_github_source/pull/32)) | ||
|
|
||
| 🎉 PostgreSQL Compatibility 🎉 |
There was a problem hiding this comment.
I recommend putting this into it's own subsection as it currently looks like this is under the Breaking Change section
There was a problem hiding this comment.
Thanks, I have updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran PR
What change(s) does this PR introduce?
🚨 Breaking Change 🚨
github__using_repo_teamto also toggle on/off theTEAMtable along with and in addition to theREPO_TEAMtable. This was done to fix issues with dependent models in our transform package, whereTEAMis only ever used in conjunction withREPO_TEAM. (#32)🎉 PostgreSQL Compatibility 🎉
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🌀
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.