Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Label-Source-Addition #22

Merged
merged 8 commits into from
Feb 17, 2022
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR adds the label source table. This was necessary as the issue_label depreciated the label column. The respective label information will now be synced within the label table.

Additionally, a few minor updates were made to the issue_label table and some spelling updates were applied.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

Since this PR removes a field from the issue_label table and adds a new source table, this will be reflected as a breaking change.

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🏷️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review February 11, 2022 20:46
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-jamie
Copy link
Contributor

ah also remember to change the package version in the README installation instructions since it's breaking

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 0ce42c2 into main Feb 17, 2022
@fivetran-sheringuyen fivetran-sheringuyen added type:bug Something is broken or incorrect update_type:models Primary focus requires model updates and removed bug labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something is broken or incorrect update_type:models Primary focus requires model updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants