Feature/enable null urls

.buildkite/pipeline.yml

@@ -58,7 +58,7 @@ steps:
     commands: |
       bash .buildkite/scripts/run_models.sh redshift
 
-  - label: ":bricks: Run Tests - Databricks"
+  - label: ":databricks: Run Tests - Databricks"
     key: "run_dbt_databricks"
     plugins:
       - docker#v3.13.0:

.buildkite/scripts/run_models.sh

@@ -18,4 +18,6 @@ cd integration_tests
 dbt deps
 dbt seed --target "$db" --full-refresh
 dbt run --target "$db" --full-refresh
-dbt test --target "$db"
+dbt test --target "$db"
+dbt run --vars '{ad_reporting__url_report__using_null_filter: false}' --target "$db" --full-refresh
+dbt test --vars '{ad_reporting__url_report__using_null_filter: false}' --target "$db"

CHANGELOG.md

@@ -1,3 +1,10 @@
+# dbt_facebook_ads v0.6.1
+[PR #25](https://github.com/fivetran/dbt_facebook_ads/pull/25) includes the following changes:
+## 🎉 Features 🎉
+- For use in the [dbt_ad_reporting package](https://github.com/fivetran/dbt_ad_reporting), users can now allow records having nulls in url fields to be included in the `ad_reporting__url_report` model. See the [dbt_ad_reporting README](https://github.com/fivetran/dbt_ad_reporting) for more details. 
+## 🚘 Under the Hood 🚘
+- Disabled the `not_null` test for `facebook_ads__url_report` when null urls are allowed.
+
 # dbt_facebook_ads v0.6.0
 
 ## 🚨 Breaking Changes 🚨:

models/facebook.yml

@@ -33,11 +33,14 @@ models:
       - name: creative_id
         description: The ID of the related creative.
       - name: creative_name
-        description: The name of the related creative.     
+        description: The name of the related creative.
       - name: base_url
         description: The base URL of the ad, extracted from the page_link and template_page_link.
         tests:
-          - not_null
+          - not_null:
+              config:
+                # Below is so we don't run this test if the user has allowed urls to have null entries
+                enabled: "{{ var('ad_reporting__url_report__using_null_filter', True) }}"
       - name: url_host
         description: The URL host of the ad, extracted from the page_link and template_page_link.
       - name: url_path

models/facebook_ads__url_report.sql

@@ -83,8 +83,12 @@ joined as (
     left join campaigns
         on ads.campaign_id = campaigns.campaign_id
     left join accounts
-        on report.account_id = accounts.account_id    
-    where creatives.url is not null
+        on report.account_id = accounts.account_id  
+
+    {% if var('ad_reporting__url_report__using_null_filter', True) %}
+        where creatives.url is not null
+    {% endif %}
+
     {{ dbt_utils.group_by(19) }}
 )