[Feature] Create option for customers to disable tag and task_tag source dependency models using variable configuration
#37
+180
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+4
to
+6
| - git: https://github.com/fivetran/dbt_asana_source.git | ||
| revision: feature/tag-variable-configs | ||
| warn-unpinned: false |
There was a problem hiding this comment.
obligatory reminder to switch
| @@ -19,5 +19,7 @@ dbt deps | |||
| dbt seed --target "$db" --full-refresh | |||
| dbt run --target "$db" --full-refresh | |||
| dbt test --target "$db" | |||
| dbt run --vars '{asana__using_tags: false, asana__using_task_tags: false}' --target "$db" --full-refresh | |||
There was a problem hiding this comment.
Suggested change
| dbt run --vars '{asana__using_tags: false, asana__using_task_tags: false}' --target "$db" --full-refresh | |
| dbt run --vars '{asana__using_tags: false, asana__using_task_tags: false, asana_tag_identifier: missing, asana_task_tag_identifier: missing}' --target "$db" --full-refresh |
This way, the run will fail if the variables aren't working right
| @@ -0,0 +1,45 @@ | |||
| {{ config( | |||
There was a problem hiding this comment.
FYI this test is failing for me on tasks with multiple tags or projects because the string_agg is aggregating them in different orders. So the rows are essentially the same, but the test thinks they're different because a, b, c is not exactly c, b, a.
I think this is fine for now/for this current ticket, but would you mind creating a FR ticket to apply predictable ordering to our string_agg'd columns?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#36]
This PR will result in the following new package version: v0.9.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
his release will introduce the following changes:
Breaking Changes
asana__using_tagsandasana__using_task_tagsto allow thetagandtask_tagsource tables to be disabled. By default, these variables are set to True. (#37)int_asana__task_tagsandasana__tagif either of the variables are set to False. This allows the downstream models to run even if the respective sourcetagandtask_tagtables don't exist. (#37)tagsandnumber_of_tagsinasana__taskif either of the variables are set to false.Under the Hood
asana__using_tagsandasana__using_task_tagsto thequickstart.ymlconfiguration to ensure when these source tables are not selected, these variables are set to false and the above changes are applied in Quickstart. (#37)asana__using_tagsandasana__using_task_tagsto our Buildkiterun_models.shscript. (#37)integration_teststo ensure no unexpected row changes occur in theasana__tagandasana_taskmodels in development. (#37)Documentation
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
New consistency tests passed for row comparisons
If you had to summarize this PR in an emoji, which would it be?
🪄