Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): add correct variable name in ad_reporting__url_report #96

Merged
merged 5 commits into from
Jul 20, 2023
Merged

fix(): add correct variable name in ad_reporting__url_report #96

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e622ef
fix: add correct variable name in ad_reporting__url_report
aleix-cd Jul 19, 2023
360ad93
chore: update changelog
aleix-cd Jul 19, 2023
b11a88e
chore: update dbt_project.yml files
aleix-cd Jul 19, 2023
3f191d7
chore: update changelog to specify version 1.5.0 + add me as contributor
aleix-cd Jul 20, 2023
82b98db
chore: change version to 1.5.0 in both dbt_project.yml files
aleix-cd Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# dbt_ad_reporting v1.4.1
aleix-cd marked this conversation as resolved.
Show resolved Hide resolved

## Bug Fixes
- Adding the correct variable name in `ad_reporting__url_report` for passthrough metrics.

aleix-cd marked this conversation as resolved.
Show resolved Hide resolved
# dbt_ad_reporting v1.4.0

## 🎉 Feature Enhancement 🎉
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'ad_reporting'
version: '1.4.0'
version: '1.4.1'

config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'ad_reporting_integration_tests'
version: '1.4.0'
version: '1.4.1'
profile: 'integration_tests'
config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion models/ad_reporting__url_report.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ aggregated as (
sum(impressions) as impressions,
sum(spend) as spend

{{ fivetran_utils.persist_pass_through_columns(pass_through_variable='ad_reporting__url_passthrough_metrics', transform = 'sum') }}
{{ fivetran_utils.persist_pass_through_columns(pass_through_variable='ad_reporting__ad_passthrough_metrics', transform = 'sum') }}

from base
{{ dbt_utils.group_by(16) }}
Expand Down