Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics woot woot #57

Merged
merged 12 commits into from
Sep 27, 2022
Merged

metrics woot woot #57

merged 12 commits into from
Sep 27, 2022

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Sep 19, 2022

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

adds metrics to the dbt package

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below) and in Hex

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🌯

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie fivetran-jamie marked this pull request as ready for review September 19, 2022 21:56
@fivetran-jamie fivetran-jamie changed the title metrics (draft) woot woot metrics woot woot Sep 19, 2022
@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-jamie is there a way to get CircleCi to pass? Or will it not be able to pass until dbt-labs/dbt_metrics v0.4.0 is released?

README.md Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to release/v1.0.1 September 27, 2022 21:32
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request to update the CHANGELOG to be consistent with past entries. Other than that, this looks good to be merged into the release branch!

CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-jamie fivetran-jamie merged commit 512f2c7 into release/v1.0.1 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants