-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/google-ads-api-default #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fivetran-joemarkiewicz! PR looks mostly good - just a couple of notes mostly similar to the google_ads
and google_ads_source
packages with the exception of a comment specific to this README
.
I'm assuming the dbt test
error here is being inherited from google_ads_source
so once you address that in the source, every downstream package should be fixed.
Like the others, I'll approve as soon as we figure out what's going on with this test case!
Thanks @fivetran-sheringuyen! I just pushed a commit that reflects the changes you requested. Let me know if you have any other questions about the test warning from the Google Source package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @fivetran-joemarkiewicz ! LGTM!
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
The
api_source
variable is now defaulted togoogle_ads
as opposed toadwords
. The Adwords API has since been depricated by Google and is now no longer the standard API for the Google Ads connector. Please ensure you are using a Google Ads API version of the Fivetran connector before upgrading this package.adwords
version of this package will be fully removed from the package in August of 2022 (when the V2 updates roll out).Additionally, the
ad_reporting
custom schema was added. It was not included previously and was included for consistency.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
The default nature of the
api_source
has changed. As such, we should treat this as a breaking change.Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🍎
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.